Closed Bug 1075665 Opened 5 years ago Closed 5 years ago

Typo in Font Inspector destructor

Categories

(DevTools :: Inspector, defect, minor)

x86_64
Linux
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: simon.lindholm10, Assigned: simon.lindholm10)

References

Details

Attachments

(1 file)

>    this.inspector.sidebar.off("layoutview-selected", this.onNewNode);

should presumably be

>    this.inspector.sidebar.off("fontinspector-selected", this.onNewNode);
Attached patch 1075665.patchSplinter Review
Haven't run this through try because I don't have access. Seems like an obvious bugfix though.
Attachment #8498274 - Flags: review?(paul)
Comment on attachment 8498274 [details] [diff] [review]
1075665.patch

Good catch! Thanks.
Attachment #8498274 - Flags: review?(paul) → review+
(In reply to Simon Lindholm from comment #1)
> Haven't run this through try because I don't have access.

If you want to fix more bugs, maybe you want to ask for a commit access level 1?
I've been meaning to! I'll see if I can get it done in the next few days.
Bug 1081727 - think you could vouch?
Depends on: 1081727
Simon, can you push to try?
Flags: needinfo?(simon.lindholm10)
Thank you Simon.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/fc10d90f1027
Assignee: nobody → simon.lindholm10
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/fc10d90f1027
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.