Closed
Bug 1075665
Opened 10 years ago
Closed 10 years ago
Typo in Font Inspector destructor
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: simon.lindholm10, Assigned: simon.lindholm10)
References
Details
Attachments
(1 file)
1.03 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
> this.inspector.sidebar.off("layoutview-selected", this.onNewNode); should presumably be > this.inspector.sidebar.off("fontinspector-selected", this.onNewNode);
Assignee | ||
Comment 1•10 years ago
|
||
Haven't run this through try because I don't have access. Seems like an obvious bugfix though.
Attachment #8498274 -
Flags: review?(paul)
Comment 2•10 years ago
|
||
Comment on attachment 8498274 [details] [diff] [review] 1075665.patch Good catch! Thanks.
Attachment #8498274 -
Flags: review?(paul) → review+
Comment 3•10 years ago
|
||
(In reply to Simon Lindholm from comment #1) > Haven't run this through try because I don't have access. If you want to fix more bugs, maybe you want to ask for a commit access level 1?
Assignee | ||
Comment 4•10 years ago
|
||
I've been meaning to! I'll see if I can get it done in the next few days.
Assignee | ||
Comment 5•10 years ago
|
||
Bug 1081727 - think you could vouch?
Assignee | ||
Comment 7•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=edfa7e84304f
Flags: needinfo?(simon.lindholm10)
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fc10d90f1027
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•