Closed Bug 1075697 Opened 5 years ago Closed 5 years ago

MozLoopService.hawkRequest is not properly reset

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox34 fixed, firefox35 fixed)

RESOLVED FIXED
mozilla35
Iteration:
35.3
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [loop-uplift])

Attachments

(1 file)

In https://hg.mozilla.org/mozilla-central/rev/b541be2a5459, the following code exists:

const origHawkRequest = MozLoopService.oldHawkRequest;
do_register_cleanup(function() {
  MozLoopService.hawkRequest = origHawkRequest;
});

However, there is no such thing as `oldHawkRequest`, so in cleanup, hawkRequest gets changed to `undefined`.

This should have been using .hawkRequest
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8498322 - Flags: review?(dmose)
Iteration: --- → 35.3
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
Comment on attachment 8498322 [details] [diff] [review]
Patch

Review of attachment 8498322 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose.  I haven't tested it, but it seems obviously correct.  Good catch!
Attachment #8498322 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/79211bb59624
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla35
Whiteboard: [loop-uplift]
Comment on attachment 8498322 [details] [diff] [review]
Patch

Approval Request Comment
Part of the staged Loop aurora second uplift set
Attachment #8498322 - Flags: approval-mozilla-aurora?
Comment on attachment 8498322 [details] [diff] [review]
Patch

Already landed, tacking for posterity.
Attachment #8498322 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.