1075697 - MozLoopService.hawkRequest is not properly reset

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

In https://hg.mozilla.org/mozilla-central/rev/b541be2a5459, the following code exists:

const origHawkRequest = MozLoopService.oldHawkRequest;
do_register_cleanup(function() {
  MozLoopService.hawkRequest = origHawkRequest;
});

However, there is no such thing as `oldHawkRequest`, so in cleanup, hawkRequest gets changed to `undefined`.

This should have been using .hawkRequest

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8498322 [details] [diff] [review]
Patch

Review of attachment 8498322 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose.  I haven't tested it, but it seems obviously correct.  Good catch!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/79211bb59624

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/79211bb59624

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8498322 [details] [diff] [review]
Patch

Approval Request Comment
Part of the staged Loop aurora second uplift set

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/028fa95c3c54

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8498322 [details] [diff] [review]
Patch

Already landed, tacking for posterity.