Closed Bug 1076370 Opened 9 years ago Closed 9 years ago

Modify file structure of Firefox.app broke repacks.

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox34 fixed, firefox35 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: Pike, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

patch rev1
4.47 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
Seems that this broke l10n repacks.

make ident


in browser/locales/Makefile.in tries to find application.ini in the wrong spot, at least.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-10-01-03-02-05-mozilla-central-l10n/mozilla-central-macosx64-l10n-nightly-de-bm86-build1-build3565.txt.gz is an example log
Looking into it.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Stephen, I'll take care of this one to free you up for the other ones.
Assignee: spohl.mozilla.bugs → robert.strong.bugs
Component: General Automation → Build Config
Product: Release Engineering → Toolkit
QA Contact: catlee
Attached patch patch rev1 — — Splinter Review 
Hi Joel, I missed this change for l10n packaging and Mac V2 signing. I also fixed a couple of typos I landed.

Pushed to oak
https://hg.mozilla.org/projects/oak/rev/eafb515f6ab6
Attachment #8498620 - Flags: review?(jmaher)
Comment on attachment 8498620 [details] [diff] [review]
patch rev1

Review of attachment 8498620 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me!  I am not a domain expert of l10n.mk files, but from what I know of the other changes required, this seems like the right thing to do.

::: toolkit/locales/l10n.mk
@@ +114,5 @@
>  	$(PYTHON) $(MOZILLA_DIR)/toolkit/mozapps/installer/l10n-repack.py $(STAGEDIST) $(DIST)/xpi-stage/locale-$(AB_CD) \
>  		$(if $(filter omni,$(MOZ_PACKAGER_FORMAT)),$(if $(NON_OMNIJAR_FILES),--non-resource $(NON_OMNIJAR_FILES)))
>  ifneq (en,$(AB))
>  ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT))
> +	mv $(STAGEDIST)/en.lproj $(STAGEDIST)/$(AB).lproj

so much nicer looking.
Attachment #8498620 - Flags: review?(jmaher) → review+
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddbbf2820441
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/ddbbf2820441
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.