Closed Bug 1076370 Opened 6 years ago Closed 6 years ago
Modify file structure of Firefox
.app broke repacks .
Seems that this broke l10n repacks. make ident in browser/locales/Makefile.in tries to find application.ini in the wrong spot, at least. http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-10-01-03-02-05-mozilla-central-l10n/mozilla-central-macosx64-l10n-nightly-de-bm86-build1-build3565.txt.gz is an example log
Looking into it.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Stephen, I'll take care of this one to free you up for the other ones.
Assignee: spohl.mozilla.bugs → robert.strong.bugs
Component: General Automation → Build Config
Product: Release Engineering → Toolkit
QA Contact: catlee
Hi Joel, I missed this change for l10n packaging and Mac V2 signing. I also fixed a couple of typos I landed. Pushed to oak https://hg.mozilla.org/projects/oak/rev/eafb515f6ab6
Attachment #8498620 - Flags: review?(jmaher)
The oak l10n repacks are succeeding with this patch http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-10-01-20-49-50-oak-l10n/
Comment on attachment 8498620 [details] [diff] [review] patch rev1 Review of attachment 8498620 [details] [diff] [review]: ----------------------------------------------------------------- looks good to me! I am not a domain expert of l10n.mk files, but from what I know of the other changes required, this seems like the right thing to do. ::: toolkit/locales/l10n.mk @@ +114,5 @@ > $(PYTHON) $(MOZILLA_DIR)/toolkit/mozapps/installer/l10n-repack.py $(STAGEDIST) $(DIST)/xpi-stage/locale-$(AB_CD) \ > $(if $(filter omni,$(MOZ_PACKAGER_FORMAT)),$(if $(NON_OMNIJAR_FILES),--non-resource $(NON_OMNIJAR_FILES))) > ifneq (en,$(AB)) > ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) > + mv $(STAGEDIST)/en.lproj $(STAGEDIST)/$(AB).lproj so much nicer looking.
Attachment #8498620 - Flags: review?(jmaher) → review+
Pushed to mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/ddbbf2820441
Target Milestone: --- → mozilla35
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
You need to log in before you can comment on or make changes to this bug.