107651 - Handle multiple file drops on mozilla (gtk build) using the text/uri-list target

Status: RESOLVED FIXED

Description

[James Henstridge]

At the moment, it is not possible to drop multiple files from a file manager
such as nautilus on mozilla.  The de-facto standard for multi-file drops is to
use the text/uri-list target.  It is not possible to handle these drops from the
javascript layer because the data format for text/uri-list drops is ascii,
rather than 2 byte unicode, so the data gets misinterpreted.

Attached is a patch that adds support for text/uri-list, by treating it like a
drop of multiple text/x-moz-url flavour items.  This should make text/uri-list
drops usable to javascript DND Observers, while not needing special knowledge of
the conventions used on X11 dnd.

Comment 1

[James Henstridge]

Created attachment 55829 [details] [diff] [review]
Convert text/uri-list drops to a multi-file text/x-moz-url drop

Comment 2

[James Henstridge]

Created attachment 55832 [details]
Simple XUL example to test text/uri-list drops

Comment 3

[Mark Hammond [:markh]]

Comment on attachment 55829 [details] [diff] [review]
Convert text/uri-list drops to a multi-file text/x-moz-url drop

r=markh

Comment 4

[Brendan Eich [:brendan]]

blizzard, can you sr= and maybe check this in?

/be

Comment 5

[Christopher Blizzard (:blizzard)]

The code looks fine.  Can you pull the two parser loops into seperate functions
to make it more readable and maintainable, please?

Comment 6

[James Henstridge]

Created attachment 56000 [details] [diff] [review]
second attempt, with text/uri-list parsing code split into helper functions

Comment 7

[Christopher Blizzard (:blizzard)]

Comment on attachment 56000 [details] [diff] [review]
second attempt, with text/uri-list parsing code split into helper functions

sr=blizzard

Comment 8

[Christopher Blizzard (:blizzard)]

Checked in on behalf of James.