Closed
Bug 107651
Opened 23 years ago
Closed 23 years ago
Handle multiple file drops on mozilla (gtk build) using the text/uri-list target
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: james, Assigned: blizzard)
Details
Attachments
(3 files)
6.94 KB,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
1.68 KB,
text/plain
|
Details | |
7.51 KB,
patch
|
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
At the moment, it is not possible to drop multiple files from a file manager such as nautilus on mozilla. The de-facto standard for multi-file drops is to use the text/uri-list target. It is not possible to handle these drops from the javascript layer because the data format for text/uri-list drops is ascii, rather than 2 byte unicode, so the data gets misinterpreted. Attached is a patch that adds support for text/uri-list, by treating it like a drop of multiple text/x-moz-url flavour items. This should make text/uri-list drops usable to javascript DND Observers, while not needing special knowledge of the conventions used on X11 dnd.
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•23 years ago
|
||
Comment on attachment 55829 [details] [diff] [review] Convert text/uri-list drops to a multi-file text/x-moz-url drop r=markh
Attachment #55829 -
Flags: review+
Comment 4•23 years ago
|
||
blizzard, can you sr= and maybe check this in? /be
Assignee: hyatt → blizzard
Assignee | ||
Comment 5•23 years ago
|
||
The code looks fine. Can you pull the two parser loops into seperate functions to make it more readable and maintainable, please?
Reporter | ||
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
Comment on attachment 56000 [details] [diff] [review] second attempt, with text/uri-list parsing code split into helper functions sr=blizzard
Attachment #56000 -
Flags: superreview+
Assignee | ||
Comment 8•23 years ago
|
||
Checked in on behalf of James.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•