taskcluster: Chunk the build tests

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lightsofapollo, Assigned: lightsofapollo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
For general performance in CI we need to split up the build tests in such a way we can run them in parallel (via chunks). It looks like we need to split up the bighttps://github.com/mozilla-b2g/gaia/blob/master/build/test/integration/build.test.js integration test at minimum so we can begin chunking out the logic.

From there we need to configure the task to run at a sane number of chunks (ideally less then 7 minutes per chunk)
(Assignee)

Updated

3 years ago
Assignee: nobody → jlal
(Assignee)

Comment 1

3 years ago
Created attachment 8500240 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24802

This could probably be considered r? but I wanted to make sure the approach makes sense first... The important change here is the addition of ./bin/build-test (which also handles chunking) and the splitting up of the huge build.tests.js into more files... The split is not completely clean as some random tests still live in that file (which is now quite reasonable size)

See: https://treeherder.allizom.org/ui/#/jobs?repo=gaia&revision=afc1bb1c88c7f6f188dfc6be4ab2927c71e13e5f
Attachment #8500240 - Flags: feedback?(ricky060709)
(Assignee)

Updated

3 years ago
Attachment #8500240 - Flags: review?(ricky060709)
Attachment #8500240 - Flags: feedback?(ricky060709)
Attachment #8500240 - Flags: feedback?
Comment on attachment 8500240 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24802

Hi James Lal,

I leaved some comments on Github. There are a lot of jshint errors since files changes are huge. 

I think we can check again to make sure our code quality.
Attachment #8500240 - Flags: review?(ricky060709) → review-
(Assignee)

Comment 3

3 years ago
Comment on attachment 8500240 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24802

Resolved comments.... Note that there are lint issues but they are ignored (and where ignored before this patch) I did not cleanup the linter errors from build.test.js ( this could be done in a follow up but my goal here is to make tests run fast )
Attachment #8500240 - Flags: review?(ricky060709)
Attachment #8500240 - Flags: review-
Attachment #8500240 - Flags: feedback?
Comment on attachment 8500240 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24802

Cool! Let's enable this feature.

r=@RickyChien thanks!
Attachment #8500240 - Flags: review?(ricky060709) → review+
(Assignee)

Comment 5

3 years ago
https://github.com/mozilla-b2g/gaia/commit/9306e431d5b559035d9656902e413816b6ca3c26
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.