If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Revert the change in bug 762282 since bug 1001317 has landed

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The issue specified in 762282 comment 1 is fixed by bug 1001317.

<===
- mDidNotifyDataEnded is flipped to true, which prevent subsequent call of this method to call ChannelMediaResource::CacheClientNotifyDataEnded, which prevent calling nsHTMLMediaElement::ResourceLoaded, and that does not change the networkState and does not fire the last progress, so the buffered bar does not update.
===>

We should revert the change in bug 762282. Otherwise it is possible to download and cache the whole file during the execution of OggReader::RangeEndTime() before MediaResource::EndSeekingForMetadata() is called. Then download end event will not be notified and the media element will stay in NETWORK_LOADING. Since the whole file is already cached, subsequent access to the media resource will not trigger HTTP channel activities and thus no download end event at all.

This bug results in timeout of test_playback.html which expect both "ended" and  "suspend" events to finish the test.

[1] http://hg.mozilla.org/mozilla-central/file/af6c928893c0/content/media/test/test_playback.html#l48
[2] http://hg.mozilla.org/mozilla-central/file/af6c928893c0/content/media/test/test_playback.html#l62
(Assignee)

Comment 1

3 years ago
Hi roc,
Does comment 0 make sense to you?
Flags: needinfo?(roc)
(Assignee)

Updated

3 years ago
Blocks: 668973
(Assignee)

Updated

3 years ago
Assignee: nobody → jwwang
(In reply to JW Wang [:jwwang] from comment #1)
> Does comment 0 make sense to you?

Yes.
Flags: needinfo?(roc)
(Assignee)

Comment 3

3 years ago
Created attachment 8500208 [details] [diff] [review]
1076691_revert_bug_762282.patch

Per comment 0, remove the changes in bug 762282.

Try: https://tbpl.mozilla.org/?tree=Try&rev=10721aa24fdd
     https://tbpl.mozilla.org/?tree=Try&rev=b037132b3777

I guess those oranges have been there for a while.
Attachment #8500208 - Flags: review?(roc)
Attachment #8500208 - Flags: review?(roc) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f13639d2f12
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5f13639d2f12
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.