bugzilla.mozilla.org will be intermittently unavailable on Saturday, March 24th, from 16:00 until 20:00 UTC.

[Stingray][Home] Implement app skeleton



Firefox OS
4 years ago
3 years ago


(Reporter: rexboy, Assigned: rexboy)


Firefox Tracking Flags

(Not tracked)


(Whiteboard: [ft:conndevices])


(1 attachment)

This bug aims for basic visual of CardUI in Home App, including:
1. clock
2. Search Bar (can be mocked)
3. CardUI (can be mocked)
4. filter tag (can be mocked)
5. edit and settings button (can be mocked)

The mocked UI components can be replaced by really functional blocks later. We can also use the UI to verify navigating function later.
Assignee: nobody → rexboy
Summary: [Stingray][Home] Implement app skeleton and visual → [Stingray][Home] Implement app skeleton
Created attachment 8500901 [details] [review]
Pull request

Patch here.
Evelyn may you help review it?
Attachment #8500901 - Flags: review?(ehung)
Blocks: 1076700

Comment 2

4 years ago
Comment on attachment 8500901 [details] [review]
Pull request

Sorry for my late review, here are my thought:

1. rename 'build/config/tv/' folder to 'build/config/smart-screen/'. I'm not sure if this should be included in your patch but this is one thing I expect.

2. As a full app, we also need l10n. Please add l10n id and properties file.

3. I think we should ask UX for the app name, to make it more official.

The overall looks good to me, please address my comments above and on the PR, and let Tzu-lin do the second review. Thanks!
Attachment #8500901 - Flags: review?(ehung)
Thanks for help!

1. Not sure how much things we need to changed; I saw some testing inside integration test for TV build. Let's file another bug for this and let build system owners review that.

2. Added in the new patch.

3. Just confirmed with Hunter, the formal name of it is just "Home" for Smartscreen. John and I prefer using "smart-" as directory prefix.
Comment on attachment 8500901 [details] [review]
Pull request

Hi Tzu-Lin, would you help review this patch and confirm if the modification is OK to you for following works. Thanks a lot!
Attachment #8500901 - Flags: review?(tzhuang)
Comment on attachment 8500901 [details] [review]
Pull request

I leave a nit comment on PR. Though it looks good to me overall.
Attachment #8500901 - Flags: review?(tzhuang) → review+

Merged. Thanks for the help.
And, based on discussion in mail, this app goes to tv_app/ now. We need follow-up changes on build scripts for it. I will add related bug number   later.
Last Resolved: 4 years ago
Resolution: --- → FIXED
See Also: → bug 1078114
Comment on attachment 8500901 [details] [review]
Pull request

Post-landing r+, accepting this patch since this is only included in tv builds.

Please find a Gaia co-owner to review the patch before creating a new app.
Attachment #8500901 - Flags: review+


3 years ago
Whiteboard: [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.