1076710 - Remove socketio-server remnants

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Unless we're going to be using socketio soon, I guess we can remove:

https://github.com/mozilla/treeherder-service/blob/f1bc715cfd81d659226bb7308ad2b9a8fbd304b1/deployment/update/update.py#L81
>  ctx.remote('{0}/service socketio-server restart'.format(settings.SBIN_DIR))

https://github.com/mozilla/treeherder-service/blob/52a653911e450fb5c5e9359438fd90a87c85b82a/deployment/supervisord/admin_node.conf#L16
> [program:socketio-server]
> command=/home/vagrant/treeherder-service/bin/run_socketio_server
> user=vagrant
> autostart=true
> autorestart=true
> stderr_logfile=/var/log/socketio/treeherder_err.log

Depending on whether we'll be using it again soon, also:

https://github.com/mozilla/treeherder-service/blob/52a653911e450fb5c5e9359438fd90a87c85b82a/bin/run_socketio_server

And other bits under:
https://github.com/mozilla/treeherder-service/tree/master/treeherder/events

Comment 1

[Ed Morley [:emorley]]

Removing the gevent-socketio/gevent-websocket deps will speed up the pip install, since we have to fetch gevent-socketio from a zip archive, which is re-checked every time, and the

Comment 2

[Ed Morley [:emorley]]

Attachment: Remove socketio remnants

Comment 3

[Mauro Doglio [:mdoglio]]

Comment on attachment 8576874 [details] [review]
Remove socketio remnants

It looks good to me.

Comment 4

[Mauro Doglio [:mdoglio]]

:fubar can you please deactivate the run_socketio script on the webheads? I can't remember if it's still running or not.

Comment 5

[Ed Morley [:emorley]]

aiui it was run via bin/run_socketio_server, which was removed in:
https://github.com/mozilla/treeherder-service/commit/3127f53e19e435a99a708f4e57ec0664eb086f61

And the configs for running bin/run_socketio_server on production were removed in bug 1090221.

Comment 6

[Kendall Libby [:fubar] (he/him)]

Cleaned up the in-puppet requirements and an old bit of logrotate. Script, etc was already gone.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/e1631abac8293893b77a9285cede26aae6f08364
Bug 1076710 - Remove socketio remnants

We're not currently using socketio - and if we start doing so in the
future we'll likely want to update to a newer version/adjust the
implementation anyway. Removing the dependencies from common.txt speeds
up the pip install on Travis. The old files will still be in version
control should we wish to refer to them :-)