1076715 - [MTP] Add B2G Supported Playback Formats for device info

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Alphan Chen [:alchen]]

We need to reply appropriate supported playback format to Initiator(PC).
Now we only reply "MTP_FORMAT_UNDEFINED, MTP_FORMAT_ASSOCIATION, MTP_FORMAT_PNG".

From MTP spec v1.1.
5.1.1.10 Playback Formats (page 41)
This field identifies by datacode the object format codes for each format that this device can understand and parse if placed on the device.If the device can carry unidentified binary objects without understanding them, it shall indicate this by including the Undefined Object (0x3000) code in its Playback Formats.

Comment 1

[Alphan Chen [:alchen]]

Attachment: (1002) Add B2G Supported Playback Formats for device info

Hi Dave,
we need reply appropriate supported formats for device info.
The new formats I added are confirmed with our playback guys.
Please take a look.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8498709 [details] [diff] [review]
(1002) Add B2G Supported Playback Formats for device info

Review of attachment 8498709 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/MozMtpDatabase.cpp
@@ +703,5 @@
>  MozMtpDatabase::getSupportedPlaybackFormats()
>  {
> +  static const uint16_t init_data[] = {MTP_FORMAT_UNDEFINED, MTP_FORMAT_ASSOCIATION,
> +                                       MTP_FORMAT_TEXT, MTP_FORMAT_HTML, MTP_FORMAT_WAV,
> +                                       MTP_FORMAT_MP3, MTP_FORMAT_MPEG, MTP_FORMAT_EXIF_JPEG, 

nit: trailing space

Comment 3

[Alphan Chen [:alchen]]

Attachment: Add B2G Supported Playback Formats for device info. r=dhylands

Try server result looks fine.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b0d11df44f70

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fb9c0806836f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb9c0806836f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This was approved for uplift in bug 1107146.

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/5372fac5205b

Comment 7

[Vincent Liu[:vliu]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/5372fac5205b