Closed
Bug 1076715
Opened 9 years ago
Closed 9 years ago
[MTP] Add B2G Supported Playback Formats for device info
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox35 fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: alchen, Assigned: alchen)
Details
Attachments
(1 file, 1 obsolete file)
We need to reply appropriate supported playback format to Initiator(PC). Now we only reply "MTP_FORMAT_UNDEFINED, MTP_FORMAT_ASSOCIATION, MTP_FORMAT_PNG". From MTP spec v1.1. 5.1.1.10 Playback Formats (page 41) This field identifies by datacode the object format codes for each format that this device can understand and parse if placed on the device.If the device can carry unidentified binary objects without understanding them, it shall indicate this by including the Undefined Object (0x3000) code in its Playback Formats.
Assignee | ||
Comment 1•9 years ago
|
||
Hi Dave, we need reply appropriate supported formats for device info. The new formats I added are confirmed with our playback guys. Please take a look.
Assignee: nobody → alchen
Attachment #8498709 -
Flags: review?(dhylands)
Comment 2•9 years ago
|
||
Comment on attachment 8498709 [details] [diff] [review] (1002) Add B2G Supported Playback Formats for device info Review of attachment 8498709 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/MozMtpDatabase.cpp @@ +703,5 @@ > MozMtpDatabase::getSupportedPlaybackFormats() > { > + static const uint16_t init_data[] = {MTP_FORMAT_UNDEFINED, MTP_FORMAT_ASSOCIATION, > + MTP_FORMAT_TEXT, MTP_FORMAT_HTML, MTP_FORMAT_WAV, > + MTP_FORMAT_MP3, MTP_FORMAT_MPEG, MTP_FORMAT_EXIF_JPEG, nit: trailing space
Attachment #8498709 -
Flags: review?(dhylands) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Try server result looks fine. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b0d11df44f70
Attachment #8498709 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/fb9c0806836f
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fb9c0806836f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
Comment 6•8 years ago
|
||
This was approved for uplift in bug 1107146. https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/5372fac5205b
Comment 7•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/5372fac5205b
status-b2g-v2.1S:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•