[MTP] Add B2G Supported Playback Formats for device info

RESOLVED FIXED in Firefox 35

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alchen, Assigned: alchen)

Tracking

unspecified
2.1 S6 (10oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox35 fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We need to reply appropriate supported playback format to Initiator(PC).
Now we only reply "MTP_FORMAT_UNDEFINED, MTP_FORMAT_ASSOCIATION, MTP_FORMAT_PNG".

From MTP spec v1.1.
5.1.1.10 Playback Formats (page 41)
This field identifies by datacode the object format codes for each format that this device can understand and parse if placed on the device.If the device can carry unidentified binary objects without understanding them, it shall indicate this by including the Undefined Object (0x3000) code in its Playback Formats.
Hi Dave,
we need reply appropriate supported formats for device info.
The new formats I added are confirmed with our playback guys.
Please take a look.
Assignee: nobody → alchen
Attachment #8498709 - Flags: review?(dhylands)
Comment on attachment 8498709 [details] [diff] [review]
(1002) Add B2G Supported Playback Formats for device info

Review of attachment 8498709 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/MozMtpDatabase.cpp
@@ +703,5 @@
>  MozMtpDatabase::getSupportedPlaybackFormats()
>  {
> +  static const uint16_t init_data[] = {MTP_FORMAT_UNDEFINED, MTP_FORMAT_ASSOCIATION,
> +                                       MTP_FORMAT_TEXT, MTP_FORMAT_HTML, MTP_FORMAT_WAV,
> +                                       MTP_FORMAT_MP3, MTP_FORMAT_MPEG, MTP_FORMAT_EXIF_JPEG, 

nit: trailing space
Attachment #8498709 - Flags: review?(dhylands) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fb9c0806836f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in before you can comment on or make changes to this bug.