Closed Bug 1076720 Opened 5 years ago Closed 5 years ago

Toggling filters twice causes job icon to not be rendered correctly (blank space)

Categories

(Tree Management :: Treeherder, defect, P1)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: whimboo, Assigned: camd)

References

(
URL
)

Details

Attachments

(2 files)

screenshot (initial load)
6.87 KB, image/png
Details
after toggling twice
6.24 KB, image/png
Details 
Toggling doesn't seem to work for me. When I toggle twice I expect to see the colored letters again instead of empty spaces. Maybe something wrong with the CSS styling?

Steps:
1. Open https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1e1d2e5f4607
2. Toggle successful jobs
3. Toggle successful jobs again

With step 2 the successful jobs are hidden, and step 3 doesn't bring them back. It's an empty space.
Yeah that isn't right, can repro.

Thank you for filing :-)
Blocks: treeherder-dev-transition
OS: Linux → All
Priority: -- → P1
Hardware: x86_64 → All
Tweaking summary since I struggled to find this again when Ryan reported a similar issue.

Another STR:

1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central & wait for page to finish loading.
2) Press 'u'.
3) Press 'u' again.

Expected:
Page at step #1 and #3 look identical

Actual:
The job symbols are not fully rendering.
Summary: Toggling twice e.g. success, does not show results again but empty space → Toggling filters twice causes job icon to not be rendered correctly (blank space)
This is pretty problematic for the sheriff workflow.
Cameron, could you take a look? Related to the bootstrap update?
Flags: needinfo?(cdawson)
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/f1e27d6fb6e12a38ac64914f998f5e9d350fcb72
bug 1076720 - accidental removal of setting display inline on job show

https://github.com/mozilla/treeherder-ui/commit/837a4ef18f9d196319c843ed5cb7f462a8d931f6
Merge pull request #220 from mozilla/bug-1076720-toggle-unclassified

bug 1076720 - accidental removal of setting display inline on job show
This change will re-break bug 1067486 afaik, so one of the two bugs will have to be fixed in a different way.
Both [nothing] and inline-block worked during my initial testing; :camd and I just collaborated a bit in channel and he's pushed the fix which switches the injection to inline-block.

:camd just tried it with a local server and says it works so he is pushing it to dev. So we should have both a functioning set of filters, and handle the edge case for bug 1067486 above, for non-wrapping jobs when sufficient job row space is present.
OK, we have changes to all these issues now on master.  Need to push to production (probably tomorrow morning).  We are currently testing on stage.  the UI looks good on both issues.  inline-block was the right setting there.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(cdawson)
Resolution: --- → FIXED
See Also: → 1067486
Assignee: nobody → cdawson
Looks great. Thanks!
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3161965982be99c49114b6f346a2181203117e6d
bug 1076720 - accidental removal of setting display inline on job show

https://github.com/mozilla/treeherder/commit/89bca1970cabc1e1c028c5baa47f429d0eb3c5f2
Merge pull request #220 from mozilla/bug-1076720-toggle-unclassified

bug 1076720 - accidental removal of setting display inline on job show
You need to log in before you can comment on or make changes to this bug.