1076762 - [UX] define contacts import success and error reporting

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

When a user start importing, the 'Import Contacts' button state is disabled and a spinner appears next to the caption.

When the import finishes, with error or successfully, there's no reporting mechanism in place to show this to the user, except for hiding the spinner and re-enabling the 'Import Contacts' button.

The information we have available:
 * On success: `{ total: 25, success: 3 }`, which means out of 25 Google contacts we imported 2 successfully.
 * On error: `{ message: "Something went wrong, English text." }`

Comment 1

[Darrin Henein [:darrin]]

If the import was successful, I don't think we need to inform the user. If it throws an error, we can use the existing Error notification mechanism to report the failure. Does the import error give us strings to use?

Comment 2

[Mike de Boer [:mikedeboer]]

(In reply to Darrin Henein [:darrin] from comment #1)
> Does the import error give us strings to use?

In the case of an authentication error: no. We _do_ know if authentication failed, we can map to a string that we provide in loop.properties. Can you provide such a string?

Other errors do have ok-ish English messages. But there's no solution (yet) for localizing these - the benefit of that is very low, because they are serious internal DB errors, which should never happen.

Comment 3

[Darrin Henein [:darrin]]

It's my understanding that it's too late to add strings for 35... can you confirm/deny this? If we can add a string for this error, I will get one for you asap.

Comment 4

[:shell escalante]

we'd need the string in the next week to add to 36, for uplifting strings to fix in 36.

Comment 5

[Darrin Henein [:darrin]]

Mike, can you provide a list of errors we want to cover and then NI Matej to get strings for them? Thanks!

Comment 6

[Mike de Boer [:mikedeboer]]

The error codes/ messages that may be returned during import are:

 - `Google authentication failed with error: <someerror>` - the error specified in <someerror> is not really interesting to the user. The user should just retry the import.
 - `Unknown response from Google` - this will never happen, but also in this case the user should retry the import. It is a _very_ similar error to the one stated above.
 - `Popup window was closed before authentication succeeded` - this means that the OAuth popup window was closed before the authentication process could finish. The user should retry.
 - `401 Access Denied` - and similar HTTP response codes. In all these cases the user should retry the import process. This may happen too, for example, when the internet connection hiccups.

A single, all-encompassing error message with a pointer to retry the import might be enough here to inform the user properly. I'll leave that up to you, Matej.

Comment 7

[Matej Novak [:matej]]

Would this be enough to cover it?

"Some contacts could not be imported. Please try again."

Comment 9

[:shell escalante]

Hi Philip, comment 9 from the Contacts UX review was around errors: https://bug1075203.bugzilla.mozilla.org/attachment.cgi?id=8510174

does the error message below cover what you were looking for (and the discussion between UX and Eng on what's possible to display)?  Comment 7 from Matej has proposed wording.  there is also bug 1076764 for implementing the error message.

Comment 10

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Yes that's definitely better.

I've been encountering this generic »Something went wrong« error in a couple of places (e.g. connecting etc.). We should find better versions for as many of these as possible. Is there any list of error messages that we can look at in order to do that?

Comment 11

[Maire Reavy [:mreavy]]

I talked to Matt, and we're going to use bug 1076764 as the implementation bug, and treat this as the UX bug.