1076886 - Chief deploy should include Github changelog in log + New Relic notification

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder: Infrastructure, defect, P3)

Description

[Ed Morley [:emorley]]

Similar to what TBPL does, we should add links to the changelog in the output from update.py

eg:
https://github.com/mozilla/treeherder-service/compare/56005e4...43e47cd

This will allow us to quickly figure out what each deploy actually did.

Comment 1

[Ed Morley [:emorley]]

Prior art:
https://github.com/mozilla/mozillians/blob/master/scripts/update/update.py#L74
https://github.com/mozilla/bedrock/blob/master/bin/update/deploy_base.py#L154

Comment 2

[Ed Morley [:emorley]]

Attachment: Don't specify the wrong revision to New Relic

Stopgap until we add the proper SHA/changelog for real - which will be much simpler once bug 1056877 (the UI+service repo merge) is complete.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bd60d36364491789085cad44c0dd5c799ecf993b
Bug 1076886 - Deploy: Don't specify the wrong revision to New Relic

We're passing settings.UPDATE_REF, which is the default ref value, not
the actual value that was passed via the Chief web UI. As such, New
Relic was always displaying the revision deployed as "master", even if
it was a non-master branch deploy. Ideally we'd use the value of 'ref'
from pre_update(), but that's not available during the deploy() task
(the script is run in three independent stages & Chief unhelpfully only
passes 'ref' to the first stage), so we'll have to read it back from the
media/revision file - which will require more mangling in bug 1076886.

For now, seeing as the 'revision' property is optional, lets just omit
it, rather than setting it to a sometimes wrong value.

Comment 4

[Ed Morley [:emorley]]

Note to self: Also shorten the SHA stored in media/revision so the IRC bot doesn't wrap the compare URL over two lines, like:
22:35 <treeherder-stage> https://github.com/mozilla/treeherder-service/compare/85079286994734645e24d5d1a1045d48787a4c62
22:35 <treeherder-stage> ...1166872

(Now the UI repo has been merged in, these URLs should actually work, since we won't have two SHAs mixed together)

Comment 5

[Ed Morley [:emorley]]

Wontfix since moving to Heroku.
Bug 1165229 can handle this for Heroku.