Closed
Bug 1076943
Opened 10 years ago
Closed 10 years ago
forget icon has white border (non-transparent background)
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 35
People
(Reporter: Gavin, Assigned: Dolske)
References
Details
Attachments
(1 file, 1 obsolete file)
2.69 KB,
patch
|
jaws
:
review+
Dolske
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Screenshot: http://cl.ly/image/3i3B0c2I0V10
Flags: needinfo?(shorlander)
Reporter | ||
Comment 1•10 years ago
|
||
The screenshot is from 10.9, non-Retina.
Assignee | ||
Comment 3•10 years ago
|
||
Looking at http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/panic-panel/, it seems only the header.png flavor has a non-transparent background.
Assignee | ||
Updated•10 years ago
|
Blocks: Forget-button
Assignee | ||
Comment 4•10 years ago
|
||
Assignee: nobody → dolske
Attachment #8498939 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8498948 [details] [diff] [review] Patch v.1 Review of attachment 8498948 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8498948 -
Flags: review+
Comment 6•10 years ago
|
||
Dolske, can you make sure that this gets uplifted to the necessary places?
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7b8254083c17
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8498948 [details] [diff] [review] Patch v.1 [Triage Comment] Approving for aurora since it's part of the hot bug 1069300 work, and is a trivial image replacement.
Attachment #8498948 -
Flags: approval-mozilla-aurora+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/271f027abcc5
status-firefox34:
--- → fixed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7b8254083c17
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Assignee | ||
Comment 11•10 years ago
|
||
Landed in alder: https://hg.mozilla.org/projects/alder/rev/36221eb238be (based on landing in comment 9)
Whiteboard: [fixed-alder]
Comment 12•10 years ago
|
||
I was able to reproduce this bug on Nightly 35.0a1 (2014-10-02) using Ubuntu 14.04 x86 and Mac OSX 10.9.5. Verified fixed on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 14.04 x86 using Beta 34.0b2 (20141020184313) and on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 13.10 x64 using Aurora 35.0a2(2014-10-22). This fix can be marked as verified. [bugday-20141022]
Comment 13•10 years ago
|
||
I also verified this issue as fixed on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 13.10 x64 using Latest Alder (2014-10-22) downloaded from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-alder/. [bugday-20141022]
Comment 14•10 years ago
|
||
Marking verified per previous comments. Thanks!
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
status-firefox33:
--- → affected
status-firefox35:
--- → fixed
Comment 15•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-release/rev/36221eb238be
Whiteboard: [fixed-alder]
Updated•10 years ago
|
Comment 16•10 years ago
|
||
Marking tracking flags status based on testing that was done in comment 12 and comment 13.
You need to log in
before you can comment on or make changes to this bug.
Description
•