Closed Bug 1076949 Opened 10 years ago Closed 10 years ago

Enable TransactionMiddleware for everything in zamboni

Categories

(Marketplace Graveyard :: General, defect, P2)

Product:
Marketplace Graveyard
Component:
General
Version:
Avenir
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-10-21

People

(Reporter: mat, Assigned: mat)

Details

(Whiteboard: [repoman]) 

Currently, we only enable TransactionMiddleware for the API - for everything else, the view decides what to wrap in transactions.

We should attempt to enable TransactionMiddleware everywhere, wrapping every view in a transaction, that would probably eliminate some weird bugs like bug 899082.
Priority: -- → P2
Whiteboard: [repoman]
Assignee: nobody → mpillard
OS: Linux → All
Hardware: x86_64 → All
Version: 1.5 → Avenir
Status: NEW → ASSIGNED
Component: Code Quality → General
Target Milestone: --- → 2014-10-14
Under Django 1.7 I see: "RemovedInDjango18Warning: TransactionMiddleware is deprecated in favor of ATOMIC_REQUESTS."

Should we move to that instead?
Yes, I'll also directly change commit_on_success and commit_manually in my PR.
Fixed in https://github.com/mozilla/zamboni/commit/a12d15a59bb3cca6c747ac7f25a3abcfc3dc4aa9 (though I kept the deprecated stuff, we'll deal with that in the django 1.7 PR as the changes were a bit invasive)

QA:
- Please just do a basic app submission and reviewer approval/reject test.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2014-10-14 → 2014-10-21
Verified as fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.