1077003 - [System] Layout problem in browser with SHB enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

It seems that there's an empty gap in the browser now.

I'm only seeing this in master and not 2.1

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Let me see if I can write a test for this.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8499012 [details] [review]
Github pull request

I thought about writing a test for this one, but I'm not sure how much value it would be as these menus are getting changed in 2.2 to be of the new style. The test would also be pretty complex.

Could you guys take a look?

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Screenshot of problem

Comment 4

[Kevin Grandon :kgrandon]

Turns out this was caused by bug 1074033. Assuming we get a review we could land them together.

Comment 5

[Kevin Grandon :kgrandon]

Note: You may need the patch from bug 1074033 to test this.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Let's just fix this in bug 1074033, and mark this as resolved since that one was backed out.

Also of note, this is really similar to bug 1074123. The problem is that we dynamically resize the .dialog-overlay container in the system app sometimes [1][2]. So for instance, before opening the keyboard we want a bottom of the SHB height. After opening and closing keyboard, the container is aware of SHB height, and we want a bottom of 0 at that point. It is really brittle in it's current state, so I'm trying to come up with a better solution right now.

1.) https://github.com/mozilla-b2g/gaia/blob/206ec9ceb12c6e9755ac367f3e313b9f2e04b610/apps/system/js/modal_dialog.js#L157
2.) https://github.com/mozilla-b2g/gaia/blob/206ec9ceb12c6e9755ac367f3e313b9f2e04b610/apps/system/js/system_dialog.js#L173

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8499012 [details] [review]
Github pull request

Clearing review flags.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

After some investigation, this dialog doesn't live inside of .dialog-overlay, but rather the browser app window. However, I believe the same thing applies since that window get's resized in much the same way as .dialog-overlay. Sorry about the noise here.