1077018 - Back out extra, untracked code committed as part of bug 1008764

Status: RESOLVED WORKSFORME

(Bugzilla :: bugzilla.org, defect)

Description

[Mark Côté [:mcote]]

sgreen's commit for bug 1008764[1] included a bunch of changes not present in the final, reviewed patch, nor is there any mention of it in any comment in the bug.

It should be backed out, and, if appropriate, landed in a separate bug, so that we can track it properly.  I'm betting it was committed by accident, but we're not sure, and we don't know if any future commits relies on those extra changes, so I'm filing this bug to first investigate before backing out.

[1] http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commitdiff;h=9bd3f08 [github]

Comment 1

[Simon Green]

Sorry about that.

Comment 2

[Frédéric Buclin]

Could you tell us a bit more about where the extra code comes from? You added bug 1052202 to the See Also field, but I don't see how that's related to this bug.

Comment 3

[Frédéric Buclin]

You committed bug 39120 together with bug 1008764, not 1052202. It doesn't make sense to backout that part of the code and re-commit it separately. So closing this bug. Fortunately, bug 39120 already got r+ when it has been accidentally committed, but unfortunately, it didn't get a+ yet.

Please check the list of modified files next time. You should use a separate installation for checkins, to not mess several patches together.