1077022 - [Keyboard] European Portuguese (pt-PT) based keyboard is missing from gaia repository

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Seth Miko [:SMiko]]

Description:
When users enable the Portuguese based keyboard they will observe the keyboard lacks autocorrection.
   
Setup:
-Confirm Autocorrection is enabled
-Setup custom gaia build:
CD into gaia folder
 + git pull
 + git checkout v2.1
 + git pull
 + MOZILLA_OFFICIAL=1 GAIA_KEYBOARD_LAYOUTS=en,pt-PT make reset-gaia

Repro Steps:
1) Update a Flame device to BuildID: 20141001000202
2) Enable the Macedonian based keyboard and enter Rocketbar
3) Start typing on keyboard and observe lack of autocorrection 
  
Actual:
Macedonian based keyboard lacks autocorrection
  
Expected: 
Autocorrection is present
  
Flame 2.1 KitKat Base (512mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141002000202
Gaia: 94dcc25f2e34a4900ea58310c26be52bcb089161
Gecko: baaa0c3ab8fd
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Repro frequency: 3/3

Comment 1

[Seth Miko [:SMiko]]

Please ignore original description. 
Updated description:

The European Portuguese (pt-PT) keyboard is not found in the gaia repository
   
Setup:
-Confirm Autocorrection is enabled
-Setup custom gaia build:
CD into gaia folder
 + git pull
 + git checkout v2.1
 + git pull
 + MOZILLA_OFFICIAL=1 GAIA_KEYBOARD_LAYOUTS=en,pt-PT make reset-gaia

Repro Steps:
1) Update a Flame device to BuildID: 20141002000202
2) Open Settings >  Keyboards > Select Keyboards

Actual:
The European Portuguese (pt-PT) keyboard is not found.
  
Expected: 
The European Portuguese (pt-PT) keyboard is found.
  
Flame 2.1 KitKat Base (512mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141002000202
Gaia: 94dcc25f2e34a4900ea58310c26be52bcb089161
Gecko: baaa0c3ab8fd
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Delphine Lebédel]

[Blocking Requested - why for this release]:

Shipping locale, please block on this

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

We have pt-BR keyboard layout, need community members to comment what difference we need to make to come out with a pt-PT layout.

Comment 4

[Delphine Lebédel]

Cláudio, could you please comment on if we would need a different keyboard and if so, what the layout should be?

Comment 5

[Cláudio Esperança [:cesperanc@]]

Yes, we need a different keyboard for pt-PT, mostly because of the € symbol. 

I've opened a bug a few days ago, with the keyboard layout as a patch for pt-PT but it was probably wrongly categorized by me so no one noticed it. For reference here is the link for this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1074550.

Is this information enough?

Comment 6

[Cláudio Esperança [:cesperanc@]]

Attachment: Pull request for the missing pt-PT keyboard

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8500083 [details] [review]
Pull request for the missing pt-PT keyboard

Hi Cláudio,

Thanks for the patch.
We've changed the way to define symbol page with bug 1047837.
Please help take a look at the current definition of English or other layouts as an example (find "pages" keyword).

Please help update your patch and let me know if you need any help.

--
Sorry for not seeing your patch in another bug in a timely manner.
In general, we would get notified if you use needinfo or set a review flag to someone.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Assign to Cláudio first as he got a patch.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Could you rebase the patch? Not the that you are working on other blockers...

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: updated Patch

Patch amended to address the comment, will land this afte tree is open and CI passed.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Oh, my bad, I didn't realized the tree is closed at the moment. 

You don't really need to wait for CI. The layout is not build by default.

Comment 13

[howie [:howie]]

Triage: shipping locale, blocking.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed,
https://github.com/mozilla-b2g/gaia/commit/347918b27b7572fc8f9700b83a7513e0e8b1220f

--
Thanks for providing the patch!

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8500843 [details] [review]
updated Patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): for 2.1 product requirement to add pt-PT support.
[User impact] if declined: Cannot have native layout support for Portuguese based in Europe.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low, layout definition only.
[String changes made]: N/A

Comment 16

[Cláudio Esperança [:cesperanc@]]

(In reply to Rudy Lu [:rudyl] from comment #14)
> Landed,
> https://github.com/mozilla-b2g/gaia/commit/
> 347918b27b7572fc8f9700b83a7513e0e8b1220f
> 
> --
> Thanks for providing the patch!

Thank you for all the work.

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This should not be auto uplifted to v2.1, since we changed the format of the layout definition in v2.2.

Comment 18

[Cláudio Esperança [:cesperanc@]]

(In reply to Rudy Lu [:rudyl] from comment #17)
> This should not be auto uplifted to v2.1, since we changed the format of the
> layout definition in v2.2.

I have a pt-PT layout for v2.1. Do you want me to create a pull request to gaia v2.1 with this or do you prefer I attach the layout file here?

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Cláudio Esperança [:cesperanc@] from comment #18)
> (In reply to Rudy Lu [:rudyl] from comment #17)
> > This should not be auto uplifted to v2.1, since we changed the format of the
> > layout definition in v2.2.
> 
> I have a pt-PT layout for v2.1. Do you want me to create a pull request to
> gaia v2.1 with this or do you prefer I attach the layout file here?

Thanks for offering the help.
I've already landed this to v2.1 with the needed modification.

Comment 20

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

v2.1,
f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1

Comment 21

[sarsenyev]

Verified the issue is fixed on Flame 2.1 and 2.2
Portuguese European presents in Gaia repository with working autocorrection

Flame 2.1
Device: Flame 2.1 KK (319mb Full Flash)
BuildID: 20141022001201
Gaia: 734d3547fb6c65e8bc4dd1a52b26f70bdfee7474
Gecko: 928b18f7d8ff
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2
Device: Flame 2.2 Master KK (319mb Full Flash)
BuildID: 20141022040201
Gaia: 27a1d1baaa8e375b70e043efee67d5f2206c330b
Gecko: ae4d9b4ff2ee
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0