1077153 - shumway shouldn't use the gecko.mstone and gecko.buildID prefs

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect, P5)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Shumway currently uses the gecko.mstone and gecko.buildID prefs.  See:
http://mxr.mozilla.org/mozilla-central/search?string=gecko.mstone
http://mxr.mozilla.org/mozilla-central/search?string=gecko.buildid

The gecko.mstone and gecko.buildID prefs are actually somewhat confusingly named prefs that are local to the apps code; it's a pref for "if the Gecko milestone or buildID are not this version, then we need to rerun app registration".

(It should probably be renamed to make it more clear that that's what it is, and perhaps the code even refactored so other things can use the same redo-if-new-gecko-build with a different pref name.  But renaming it to something sensible depends on shumway not using it.)


In mozilla-central, this code was added in https://hg.mozilla.org/mozilla-central/rev/4f4f4b20efc7 , but that's probably not that useful.

Comment 1

[Till Schneidereit [:till]]

Fixed in Shumway's github repo by https://github.com/mozilla/shumway/pull/1773.

David, do you need this fix ASAP, or would including it in the next planned merge in a week be enough?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No rush; next planned merge is fine.

Comment 3

[Chris Peterson [:cpeterson]]

Fixed, but waiting for uplift.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Still hasn't reached mozilla-central, as far as I can tell.  The shumway directory hasn't been touched since October 2.

Comment 5

[Till Schneidereit [:till]]

(In reply to David Baron [:dbaron] (UTC+11) (needinfo? for questions) from comment #4)
> Still hasn't reached mozilla-central, as far as I can tell.  The shumway
> directory hasn't been touched since October 2.

It finally did reach m-c. Truly sorry about the delay :(