Closed Bug 1077154 Opened 10 years ago Closed 9 years ago

android-x86 and android are both uploading the to the same symbols path on mozilla-aurora

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlund, Unassigned)

Details

Attachments

(2 files)

normally we add a MOZ_SYMBOLS_EXTRA_BUILDID to differentiate between a platform and its respective variants. e.g. linux and linux64-asan

it looks like on mozilla-aurora we have defined MOZ_SYMBOLS_EXTRA_BUILDID for 'android-armv6'[1] but not for our other variant 'android-x86'. this results in the symbols path being the same for 'android' and 'android-x86'.

as an aside, I bet we can remove the 'android-armv6' reference from mozilla-aurora altogether since we only run that platform on esr31 now[2]. Removing it should be a no-op. But armv6 seems to be riddled in other branches too so it is probably better to do a mass clean up of that once it reaches EOL.

[1] http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/config.py#2119
[2] http://hg.mozilla.org/build/buildbot-configs/file/4d2ec7a85bd0/mozilla/config.py#l2397
dump master diff showing env change for m-a android-x86 nightly
if you feel like grepping through the dump master diff: https://bugzilla.mozilla.org/show_bug.cgi?id=1077154#c1
Attachment #8499213 - Flags: review?(nthomas)
Comment on attachment 8499213 [details] [diff] [review]
20141002_bug_1077154_android-x86_m-a-extra-symbols.patch

This will be fine for fixing up Aurora. If you're feeling energetic, I bet we could set this in the PLATFORM definition instead, and rip out all the branch specific config.
Attachment #8499213 - Flags: review?(nthomas) → review+
(In reply to Nick Thomas [:nthomas] from comment #3)
> Comment on attachment 8499213 [details] [diff] [review]
> 20141002_bug_1077154_android-x86_m-a-extra-symbols.patch
> 

oops, forgot to land this.

> This will be fine for fixing up Aurora. If you're feeling energetic, I bet
> we could set this in the PLATFORM definition instead, and rip out all the
> branch specific config.

maybe. the rules for what this value gets is kind of awkward: IIRC platforms sometimes are not given a value for this (usually the generic 32 bit one) doesn't get a value on release branches but it does on twigs (it is given just the twig branch name). The other platforms behave somewhat similiarly with twig branches vs release.
Comment on attachment 8499213 [details] [diff] [review]
20141002_bug_1077154_android-x86_m-a-extra-symbols.patch

on default: https://hg.mozilla.org/build/buildbot-configs/rev/70f0f0d375ac
Attachment #8499213 - Flags: checked-in+
Checked in code landed in production
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: