1077230 - Test DMD on TBPL (Mac)

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 1073312 will add a DMD test, but not run it on Mac. 10.8 shouldn't be a
problem, but 10.6 is asserting like this after DMD finishes its test mode
invocation:

> Assertion failure: OnLionOrLater() || gCriticalAddress.mAddr != nullptr, at /builds/slave/try-osx64-d-000000000000000000/build/xpcom/base/nsStackWalk.cpp:155

I looked at this briefly, but without access to a 10.6 machine it will be hard
to debug. The best thing might be to add support for running xpcshell tests
only on some Mac versions and then only run the test on 10.8.

Comment 1

[Robert Strong (they/them - no direct email)]

Changed dependency to the bug that actually changed GreD so xrePath points to Contents/Resources. Bug 1050944 had to choose between Contents/Resources/ or Contents/MacOS/ and Contents/Resources/ was chosen. Either choice would cause problems for some people as it has for you. As Stephen stated in bug 1077099 comment #20 you should use GreBinD to get the Gre dir with the binaries or similar method as has been done throughout the codebase to get Mac V2 signing working.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Enable the DMD test on Mac 10.8

This gets the test working on Mac on Try.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8501541 [details] [diff] [review]
Enable the DMD test on Mac 10.8

Review of attachment 8501541 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/replace/dmd/dmd.py
@@ +144,5 @@
>      # This append() call is needed to make the import statements work when this
>      # script is installed as a symlink.
>      sys.path.append(os.path.dirname(__file__))
>  
> +    bpsyms = os.environ.get('BREAKPAD_SYMBOLS_PATH', None)

os.environ.get('BREAKPAD_SYMBOLS_PATH') does the same thing.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c20e7032aa3b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c20e7032aa3b