1077335 - [Loop] Incorrect buttons order in confirmation screen for the Loop mobile application

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Checking the Loop application, we have detected that the buttons in the confirmation screens are not in the correct order as it's specified in the Building Blocks: http://buildingfirefoxos.com/building-blocks/confirm.html
where Cancel button should be at the left and the action button in red at the right.

Right now, we are seeing the incorrect order in confirmation screens for removing the entries in the call log, in the shared URLs tab, and when logging out from the Loop application but we should check all the confirmation screens used in the application.

Comment 1

[Maria Angeles Oteo (:oteo)]

Just adding that for logging out from Loop app, the right button for logging-out should be blue as it implies an action from the user

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8499537 [details] [review]
patch in github

Please remove https://github.com/mozilla-b2g/firefoxos-loop-client/pull/151/files#diff-abb510c96091b0d61e7b3e62b4199de0R52, rebase and merge this! Thanks!

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 587a53f5ab1edf494e3a0b1c9f4e9bbd6e36554c

Comment 5

[Javier de Prado]

Verified on flame, Gecko-7107b06.Gaia-c1f6089, lopp version: dbe5bf3, Ram: 512M, and spanish and english languages.