Use NSTextFieldCell for text field drawing

ASSIGNED
Assigned to

Status

()

Core
Widget: Cocoa
ASSIGNED
3 years ago
3 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8499497 [details] [diff] [review]
v1

10.10 apparently broke kHIThemeFrameTextFieldSquare drawing, which we're currently using for single-line text fields: The focus ring is too small, and the border colors are all wrong (white + light gray instead of dark gray + light gray).
NSTextFieldCell works.
Attachment #8499497 - Flags: review?(smichaud)
Markus, how far back did you test this?  Just to be sure, we should probably test it on every major version of OS X that we support (back to 10.6.8).

I could do the testing myself, but frankly I'm not sure I'd be able to see all the differences it makes.
(Assignee)

Comment 2

3 years ago
I've only tested it on 10.9 and 10.10. I'll create a try build soon which I'll use to test on the other platforms.
(Assignee)

Comment 3

3 years ago
Comment on attachment 8499497 [details] [diff] [review]
v1

And actually, on 10.9 the border color of non-disabled text fields is too light with this patch. And the border of a disabled text field is darker than of a non-disabled one...
Attachment #8499497 - Flags: review?(smichaud)
You need to log in before you can comment on or make changes to this bug.