1077371 - remove null-checks on the result of gfxFontGroup::GetFirstValidFont

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

Many callers of gfxFontGroup::GetFirstValidFont() just use the returned pointer directly (e.g. dereferencing it to call methods on the gfxFont).

This is safe because GetFirstValidFont() will always return a valid font -- unless we end up at the NS_RUNTIMEABORT in gfxFontGroup::GetDefaultFont().

Hence, we should clean up the remaining callsites that use GetFirstValidFont() and then check the result for nullptr (and do an early return, or whatever) before trying to use it.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: remove null-checks on the result of gfxFontGroup::GetFirstValidFont.

Comment 2

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af19f500d78b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af19f500d78b