add tariff to precommit lint pass

RESOLVED WONTFIX

Status

Input Graveyard
Code Quality
RESOLVED WONTFIX
4 years ago
a year ago

People

(Reporter: willkg, Assigned: L. Guruprasad, Mentored)

Tracking

Details

(Whiteboard: u=dev c=codequality p= s=input.2015q1)

+++ This bug was initially created as a clone of Bug #1015788 +++

We've got a pre-commit hook that runs flake8 across changed python files.

This bug covers adding a tariff pass and fixing the existing files.

https://github.com/mythmon/tariff
Assigning this to L. Guruprasad.

Tariff might not work right. If it doesn't, then we have a few options:

1. help fix it
2. decide to use a different library (I think there are a few out there)
3. write our own
4. decide this is a goofy thing to lint for because it doesn't matter a whole lot in the grand scheme of things and then abandon this bug as WONTFIX

L. Guruprasad: Let me know what you find and how you want to go forward with this.
Assignee: nobody → lgp171188
Mentor: willkg
Whiteboard: u=dev c=codequality p=1 s=input.2014q4 → u=dev c=codequality p= s=input.2014q4
Bumping to next quarter.
Whiteboard: u=dev c=codequality p= s=input.2014q4 → u=dev c=codequality p= s=input.2015q1
(Assignee)

Comment 3

3 years ago
http://stackoverflow.com/a/22771367 provides insights on how to use OpenStack's hacking project is helpful for extending flake8 to do the import group checks. This should be useful in case we pick this up for fixing.
Extrapolating on comment #3:

* this is the library used: https://github.com/openstack-dev/hacking
* these are OpenStack's style guidelines: http://docs.openstack.org/developer/hacking/

We talked about this on IRC and decided to WONTFIX this for now, but we can resurrect this bug later if we decide having import order linting is helpful.

Thank you L. Guruprasad for the research work!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.