add jshint to precommit lint pass

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: willkg, Assigned: lgp171188, Mentored)

Tracking

Details

(Whiteboard: u=dev c=codequality p= s=input.2014q4)

+++ This bug was initially created as a clone of Bug #1015788 +++

We've got a pre-commit hook that runs flake8 across changed python files.

This bug covers adding a jshint pass and fixing the existing files.
Blocks: 1096729
Whiteboard: u=dev c=codequality p=2 s=input.2014q4 → u=dev c=codequality p= s=input.adam
Putting this back in the 2014q4 sprint and assigning to Guruprasad. WIP PR here: https://github.com/mozilla/fjord/pull/411
Assignee: nobody → lgp171188
Status: NEW → ASSIGNED
Whiteboard: u=dev c=codequality p= s=input.adam → u=dev c=codequality p= s=input.2014q4
Blocks: 1111749
Landed it just now: https://github.com/mozilla/fjord/commit/31c2f741d4219a6c734c4493394e2a299dd09bfa

There are a few outstanding things:

1. We need to fix the vagrant provisioning script to also install flake8.

We had bug #1075563 which I "solved" by adding docs. In that bug I pontificated that it might be time for a requirements/dev.txt file which installs dev-related requirements. I'm on the fence about this at the moment.

2. jshint needs to be fine-tuned. I created bug #1111749 for that.

This doesn't need to be deployed, so marking it FIXED now.

Thank you!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Mentor: willkg
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.