Closed Bug 1077455 Opened 5 years ago Closed 5 years ago

Syncing overview (timeline) with details (profiler) view in new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

When selecting a range on the overview view, the subset should be selected in the call stack/details/profiler view
Blocks: perf-tool-v2
Depends on: 1077451, 1077449
Assignee: nobody → jsantell
Attachment #8527088 - Flags: review?(vporof)
Comment on attachment 8527088 [details] [diff] [review]
1077455-link-detail-overview-perf.patch

Review of attachment 8527088 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/test/browser_perf-details-calltree-render-02.js
@@ +10,5 @@
> +
> +  let updated = 0;
> +  CallTreeView.on(EVENTS.CALL_TREE_RENDERED, () => updated++);
> +
> +  let rendered = once(CallTreeView, EVENTS.CALL_TREE_RENDERED)

Nit: ;

::: browser/devtools/performance/views/overview.js
@@ +10,1 @@
>  /**

Nit: add newline here.
Attachment #8527088 - Flags: review?(vporof) → review+
Attachment #8527088 - Attachment is obsolete: true
Attachment #8528632 - Flags: review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9e9df8e2e7e5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.