Closed
Bug 1077455
Opened 10 years ago
Closed 10 years ago
Syncing overview (timeline) with details (profiler) view in new performance tool
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
|
15.88 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
When selecting a range on the overview view, the subset should be selected in the call stack/details/profiler view
|
Assignee | |
Updated•10 years ago
|
Blocks: perf-tool-v2
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jsantell
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8527088 -
Flags: review?(vporof)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8527088 [details] [diff] [review]
1077455-link-detail-overview-perf.patch
Review of attachment 8527088 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/performance/test/browser_perf-details-calltree-render-02.js
@@ +10,5 @@
> +
> + let updated = 0;
> + CallTreeView.on(EVENTS.CALL_TREE_RENDERED, () => updated++);
> +
> + let rendered = once(CallTreeView, EVENTS.CALL_TREE_RENDERED)
Nit: ;
::: browser/devtools/performance/views/overview.js
@@ +10,1 @@
> /**
Nit: add newline here.
Attachment #8527088 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8527088 -
Attachment is obsolete: true
Attachment #8528632 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
All performance changes, but try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a2dd3177d21f
|
||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•