1077457 - Add markers and memory to Overview->Timeline view in new performance tool

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8535929 [details] [diff] [review]
v1

Review of attachment 8535929 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.

::: browser/devtools/performance/modules/front.js
@@ +240,3 @@
>  
>      // Return start time from timeline actor
> +    let startTime = yield this._request("timeline", "start", options);

+1

::: browser/devtools/performance/test/browser_perf-details-waterfall-render-01.js
@@ +10,3 @@
>  
>    yield startRecording(panel);
> +  yield waitUntil(() => PerformanceController._markers.length);

getMarkers()?

::: browser/devtools/performance/views/details-waterfall.js
@@ +83,5 @@
>     * Called when the marker details view is resized.
>     */
>    _onResize: function () {
>      this.graph.recalculateBounds();
>      this.render();

good eye

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/947ee10e6ca2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/947ee10e6ca2