1077461 - Build call tree for memory allocations view

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Memory allocations view should not be displayed in gecko < 35 (when timeline does not exist)

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

This looks bigger than it is. Half of it is test fixes because CallTreeView and FlameGraphView were prefixed with "Js".

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

Added another test.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8556693 [details] [diff] [review]
v1

Review of attachment 8556693 [details] [diff] [review]:
-----------------------------------------------------------------

Some nits, looks good though!

::: browser/devtools/performance/modules/front.js
@@ +164,4 @@
>      if (this._target.form && this._target.form.timelineActor) {
>        this._timeline = new TimelineFront(this._target.client, this._target.form);
>      } else {
> +      this._timeline = new MockedFront([

We should still comment why this is necessary (like in Gecko < 35)

::: browser/devtools/performance/modules/recording-model.js
@@ +259,5 @@
> +      // do not have a zero epoch, and are microseconds instead of milliseconds,
> +      // so offset all of them by the start time, also converting from µs to ms.
> +      case "allocations": {
> +        let [{ sites, timestamps, frames, counts }] = data;
> +        let timeOffset = this._memoryStartTime * 1000;

nit: should use the `timeScale` constant here

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #4)
> 
> We should still comment why this is necessary (like in Gecko < 35)
> 

We still do. I moved the comment to PerformanceActorsConnection.prototype where all the actors are opened.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/5adbe8e2a52d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5adbe8e2a52d