Closed
Bug 1077523
Opened 11 years ago
Closed 11 years ago
Enable CSS source maps by default
Categories
(DevTools :: Style Editor, defect)
DevTools
Style Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: harth, Assigned: harth)
References
Details
Attachments
(2 files)
|
9.67 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
|
11.63 KB,
patch
|
Details | Diff | Splinter Review |
CSS source map support has been in for many releases and many bugs fixed. I think it's time to enable it by default as most people want to see the source they authored and not the generated one.
| Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → fayearthur
Attachment #8502614 -
Flags: review?(bgrinstead)
| Assignee | ||
Comment 2•11 years ago
|
||
^ That patch also makes the inspector context menu item "Show original sources" a checkbox, since seeing "Show CSS sources" would be confusing (I wouldn't know what that meant).
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 3•11 years ago
|
||
Comment on attachment 8502614 [details] [diff] [review]
CSS source maps on by default
Review of attachment 8502614 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good to me! Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=c450255fa707
Attachment #8502614 -
Flags: review?(bgrinstead) → review+
| Assignee | ||
Comment 4•11 years ago
|
||
Thanks for pushing to try! There was a failure. Turns out sometimes we were displaying the line number in the tooltip for a location link. Small fix so that we always display it.
Try:
https://tbpl.mozilla.org/?tree=Try&rev=3b112b9866d3
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•