1077531 - Trailing whitespaces are not trimmed for a contact's last name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Build info
Repro'd on today's 2.0 and 2.1

STR
1. Go to edit a contact
2. Add like 30 whitespaces at the end of the last name
3. Update the contact
4. Have a look at the Contact's header

Expected result
Trailing whitespaces should be trimmed (like the ones place before the last name)

Actual
You're able to see the contact's header getting smaller because of the whitespaces. See video for details: http://mzl.la/1vAbzMu

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8502477 [details] [review]
Github PR

Good job Sergi.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/2a153cea17cf9979632f7cfcde9cd617dfdecce2

Comment 4

[Kevin Grandon :kgrandon]

Reverted for not containing the proper bug number. This can cause all kinds of headaches down the road. I've gone ahead and re-landed the original commit, but modified the commit to include the bug number and reviewer.

Revert: https://github.com/mozilla-b2g/gaia/commit/41d7d3e26c4e02fbe5acaad1b58d61edd6fbcf4d
Re-land: https://github.com/mozilla-b2g/gaia/commit/506851d20f6b5ab00ca19db37b448281313d021c