Closed Bug 1077531 Opened 9 years ago Closed 9 years ago

Trailing whitespaces are not trimmed for a contact's last name

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 affected)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)
Tracking Flags:
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- affected

People

(Reporter: jlorenzo, Assigned: sergi)

Details

Attachments

(1 file)

Github PR
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review 
Build info
Repro'd on today's 2.0 and 2.1

STR
1. Go to edit a contact
2. Add like 30 whitespaces at the end of the last name
3. Update the contact
4. Have a look at the Contact's header

Expected result
Trailing whitespaces should be trimmed (like the ones place before the last name)

Actual
You're able to see the contact's header getting smaller because of the whitespaces. See video for details: http://mzl.la/1vAbzMu
Assignee: nobody → sergi.mansilla
Target Milestone: --- → 2.1 S6 (10oct)
Attached file Github PR — 

        Attachment #8502477 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8502477 [details] [review]
Github PR

Good job Sergi.

        Attachment #8502477 -
        Flags: review?(francisco) → review+

    
    

    
  
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/2a153cea17cf9979632f7cfcde9cd617dfdecce2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Reverted for not containing the proper bug number. This can cause all kinds of headaches down the road. I've gone ahead and re-landed the original commit, but modified the commit to include the bug number and reviewer.

Revert: https://github.com/mozilla-b2g/gaia/commit/41d7d3e26c4e02fbe5acaad1b58d61edd6fbcf4d
Re-land: https://github.com/mozilla-b2g/gaia/commit/506851d20f6b5ab00ca19db37b448281313d021c

          You need to log in
          before you can comment on or make changes to this bug.