Closed
Bug 1077559
Opened 10 years ago
Closed 9 years ago
Consistent naming for GeckoContentController implementations
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: botond, Assigned: kats)
References
Details
Attachments
(2 files)
7.21 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
10.71 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
The GeckoContentController interface [1] currently has 5 implementations. Their names are: - RemoteContentController [2] (for B2G content processes) - ParentProcessController [3] (for the B2G parent process) - APZController [4] (for Metro) - APZCTMController [5] (for Mac) - APZCCallbackHandler [6] (for Fennec) That's quite a variety. I'd like them to have uniform, consistent names instead. (APZCCallbackHandler is the worst offender, IMO, as it sounds very much like APZCCallbackHelper [7], which is a cross-platform, content-side component). [1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/public/GeckoContentController.h?rev=5bccb951e71f#20 [2] http://mxr.mozilla.org/mozilla-central/source/layout/ipc/RenderFrameParent.cpp?rev=3a582ed49923#79 [3] http://mxr.mozilla.org/mozilla-central/source/widget/gonk/ParentProcessController.h?rev=fb97d6af06af#14 [4] http://mxr.mozilla.org/mozilla-central/source/widget/windows/winrt/APZController.h?rev=22a756462d5d#25 [5] http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsChildView.mm?rev=8e7c9373c362#400 [6] http://mxr.mozilla.org/mozilla-central/source/widget/android/APZCCallbackHandler.h?rev=4ffa223f053f#19 [7] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/util/APZCCallbackHelper.h?rev=6030bd4e48f8#25
Updated•10 years ago
|
Blocks: gfx-target-2.2
Assignee | ||
Comment 1•10 years ago
|
||
dvander is in the process of unifying some/all of these into a ChromeProcessController in bug 1110540
See Also: → 1110540
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #0) > - RemoteContentController [2] (for B2G content processes) This will stay. > - ParentProcessController [3] (for the B2G parent process) This has been merged into ChromeProcessController > - APZController [4] (for Metro) This has been deleted in bug 1039866 > - APZCTMController [5] (for Mac) This has been merged into ChromeProcessController > - APZCCallbackHandler [6] (for Fennec) This remains, I'll clean it up.
Assignee: nobody → bugmail.mozilla
Assignee | ||
Updated•9 years ago
|
No longer blocks: gfx-target-2.2
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8597299 -
Flags: review?(botond)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8597300 -
Flags: review?(botond)
Assignee | ||
Comment 5•9 years ago
|
||
CC'ing danilo as an FYI also.
OS: Gonk (Firefox OS) → Android
Hardware: ARM → All
Reporter | ||
Updated•9 years ago
|
Attachment #8597299 -
Flags: review?(botond) → review+
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8597300 [details] [diff] [review] Part 2 - Rename APZCCallbackHandler to AndroidContentController Review of attachment 8597300 [details] [diff] [review]: ----------------------------------------------------------------- Yay naming consistency!
Attachment #8597300 -
Flags: review?(botond) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c78dde16ea78 https://hg.mozilla.org/integration/mozilla-inbound/rev/ccd270cfe90b
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c78dde16ea78 https://hg.mozilla.org/mozilla-central/rev/ccd270cfe90b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•