Closed Bug 1077579 Opened 5 years ago Closed 5 years ago

[meta] SHB issue tracking

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikehenrty, Unassigned)

References

Details

(Keywords: meta, Whiteboard: [systemsfe])

User Story

Still need tests for the following:
 * bug 1068470
 * bug 1074123
 * bug 1078904
 * bug 1078911
 * bug 1068470
 * bug 1072728

Attachments

(9 files)

Let's use this meta bug to track all the SHB issues we've been seeing in 2.1, and write tests for as many problems as we can.

Please help out by adding any SHB bugs to this tracker.
Flags: needinfo?(kgrandon)
Depends on: 1068470
This is still a WIP. I'd like to add some more assertions to check general height and layout of elements.
Flags: needinfo?(kgrandon)
Depends on: 1077700
Attachment #8499810 - Attachment description: Pull request - Coverage for bug 1074580 → Pull request - Coverage for bug 1074580, part 1
Comment on attachment 8499810 [details] [review]
Pull request - Coverage for bug 1074580

Mike - these are not perfect, but they are a start. I'd like to land these for now and we should be able to continue to iterate on them.

The biggest thing right now is that I have to figure out what's going on with bug 1077700. Once that's solved I'll revisit these and add some more assertions. let me know what you think.
Attachment #8499810 - Flags: review?(mhenretty)
No longer depends on: 1077700
Comment on attachment 8499810 [details] [review]
Pull request - Coverage for bug 1074580

I've made some updates and this should fully cover bug 1074580 now. I forgot that the requestFullScreen() had to be based on user action.
Attachment #8499810 - Attachment description: Pull request - Coverage for bug 1074580, part 1 → Pull request - Coverage for bug 1074580
Comment on attachment 8499810 [details] [review]
Pull request - Coverage for bug 1074580

Eli - Could you also take a look at this if you have time? Thanks!
Attachment #8499810 - Flags: review?(eperelman)
Comment on attachment 8499894 [details] [review]
Pull request - Coverage for bug 1072231

Moving the review to the pull request that has more tests. (This is inclusive of the other two here)
Attachment #8499894 - Flags: review?(mhenretty)
Attachment #8499894 - Flags: review?(eperelman)
Attachment #8499810 - Flags: review?(mhenretty)
Attachment #8499810 - Flags: review?(eperelman)
This makes tests for: 1074580, 1048593, and 1072231.
Tests are required for the following bugs still: 1068470, 1074123, 1064595, 1074608
Attachment #8499894 - Attachment description: Pull request - Coverage for bug 107223 → Pull request - Coverage for bug 1072231
Adding a patch to cover bug 1064595.

Tests are required for the following bugs still: 1068470, 1074123, 1074608
Comment on attachment 8499900 [details] [review]
Pull request - Coverage for bug 1064595

Moving reviews to latest bug which contains all tests.
Attachment #8499900 - Flags: review?(mhenretty)
Attachment #8499900 - Flags: review?(eperelman)
Attachment #8499894 - Flags: review?(mhenretty)
Attachment #8499894 - Flags: review?(eperelman)
Not sure of the best way to track these, so I'm going to use the user story.

Need tests for bugs: 1068470, 1074123, 1074608, 1005417, 1054716
User Story: (updated)
User Story: (updated)
Added a test for bug 1074608, but it appears the bug is still broken on master. Going to do some investigation.
User Story: (updated)
Attachment #8499900 - Flags: review?(eperelman) → review+
Depends on: 1077567
User Story: (updated)
Comment on attachment 8499900 [details] [review]
Pull request - Coverage for bug 1064595

Let's go with Eli's review for now. Thanks!
Attachment #8499900 - Flags: review?(mhenretty)
Depends on: 1078822
Depends on: 1078436
Depends on: 1075105
Depends on: 1078904
Depends on: 1078911
User Story: (updated)
User Story: (updated)
Hey Mike or Eli - Could either of you guys review these patches? Thanks!
Attachment #8501252 - Flags: review?(mhenretty)
Attachment #8501252 - Flags: review?(eperelman)
Comment on attachment 8501252 [details] [review]
Pull request - Coverage for bug 1075105

r+ for the SHB notification test.
Attachment #8501252 - Flags: review?(eperelman) → review+
Comment on attachment 8501252 [details] [review]
Pull request - Coverage for bug 1075105

Both tests looking good.
Attachment #8501252 - Flags: review?(mhenretty) → review+
No longer depends on: 1078436
Of the bugs blocking this one, only tests are needed for the current bugs which are open. I hope that we can land tests with the bug fixes, but if not I will monitor them here and ensure we get tests added for the future.

 * bug 1068470
 * bug 1074123
 * bug 1078904
 * bug 1078911
 * bug 1068470
Depends on: 1079525
Depends on: 1072728
User Story: (updated)
Kevin, could you help me take a look at these Mocks tomorrow. Having trouble getting the System app to recognize them.
(In reply to Michael Henretty [:mhenretty] from comment #27)
> Created attachment 8502172 [details] [review]
> [Gaia PR] Coverage for bug 1074123
> 
> Kevin, could you help me take a look at these Mocks tomorrow. Having trouble
> getting the System app to recognize them.

Sure - if it's a blocker I suppose we can land without the tests. I'll be out tomorrow, but let's try on Friday..
Depends on: 1080350
Depends on: 1082071
Going to close this as we are now tracking testing with the in-testsuite flag for 2.1 blockers. The only remaining bug here is bug 1074123 which shows up in our queries. Go tests go!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1082885
Depends on: 1084458
Blocks: 1089759
Depends on: 1089795
Depends on: 1088352
Depends on: 1069608
Depends on: 1089505
Depends on: 1096643
You need to log in before you can comment on or make changes to this bug.