1077599 - Rounding corners of buttons

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[:shell escalante]

bug from UX review in bug 1065441 - visual: https://bug1065441.bugzilla.mozilla.org/attachment.cgi?id=8497452

#6 Rounded corners on cancel button
#17 Rounded corners on feedback button

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Also removed some tag selectors and some descendent selectors and replaced them with child selectors.

Comment 2

[Tomasz Kołodziejski [:tomasz]]

I was just wondering if we could simplify buttons styling and have some basic button class with the defaults. Right now we have quite many "border-radius: 2px": http://dxr.mozilla.org/mozilla-central/search?q=%22border-radius%3A+2px%22+path%3Abrowser%2Fcomponents%2Floop. Some of the code tries to be styled a little bit like Bootstrap (btn class) but some of it does not. What do you think?

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8510651 [details] [diff] [review]
Patch

Review of attachment 8510651 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/020fe1a54d84

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Tomasz Kołodziejski [:tomasz] from comment #2)
> I was just wondering if we could simplify buttons styling and have some
> basic button class with the defaults. Right now we have quite many
> "border-radius: 2px":
> http://dxr.mozilla.org/mozilla-central/search?q=%22border-
> radius%3A+2px%22+path%3Abrowser%2Fcomponents%2Floop. Some of the code tries
> to be styled a little bit like Bootstrap (btn class) but some of it does
> not. What do you think?

(just seeing your comment now, please use needinfo to make sure that questions/comments don't go unnoticed)

Yeah it's a shared criticism of the CSS that it could use better organization. We're not planning on fixing up the CSS though until the feature is fully released and then we will start on refactoring/clean-up.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/020fe1a54d84

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97384b6dc451

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8510651 [details] [diff] [review]
Patch

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only

Comment 9

[:shell escalante]

Please ignore.  This is a test on 2 bugs that i'm hoping only I'll notice (since they are so old) to see if this type of multi-change works.  will change status back to resolved fix just to keep clean data.