Rounding corners of buttons

RESOLVED FIXED in Firefox 35

Status

defect
P1
normal
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: shell, Assigned: jaws)

Tracking

unspecified
mozilla36
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

(Whiteboard: [UX], )

Attachments

(1 attachment)

Reporter

Description

5 years ago
bug from UX review in bug 1065441 - visual: https://bug1065441.bugzilla.mozilla.org/attachment.cgi?id=8497452

#6 Rounded corners on cancel button
#17 Rounded corners on feedback button
Reporter

Updated

5 years ago
Priority: -- → P1
Target Milestone: --- → mozilla35
Flags: qe-verify-
Flags: firefox-backlog+
Summary: [meta] rounding corners of buttons → [UX] rounding corners of buttons
Whiteboard: [ux]
Reporter

Updated

5 years ago
backlog: --- → Fx35+
Flags: qe-verify- → qe-verify?
Summary: [UX] rounding corners of buttons → Rounding corners of buttons
Whiteboard: [ux]
Reporter

Updated

5 years ago
Whiteboard: [UX]
Reporter

Updated

5 years ago
Target Milestone: mozilla35 → ---
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 36.1
Points: --- → 1
Points: 1 → 2
Posted patch PatchSplinter Review
Also removed some tag selectors and some descendent selectors and replaced them with child selectors.
Attachment #8510651 - Flags: review?(dmose)
I was just wondering if we could simplify buttons styling and have some basic button class with the defaults. Right now we have quite many "border-radius: 2px": http://dxr.mozilla.org/mozilla-central/search?q=%22border-radius%3A+2px%22+path%3Abrowser%2Fcomponents%2Floop. Some of the code tries to be styled a little bit like Bootstrap (btn class) but some of it does not. What do you think?
Attachment #8510651 - Flags: review?(mdeboer)
Comment on attachment 8510651 [details] [diff] [review]
Patch

Review of attachment 8510651 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #8510651 - Flags: review?(mdeboer)
Attachment #8510651 - Flags: review?(dmose)
Attachment #8510651 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/020fe1a54d84
Flags: qe-verify? → qe-verify-
Whiteboard: [UX] → [UX][fixed in fx-team]
(In reply to Tomasz Kołodziejski [:tomasz] from comment #2)
> I was just wondering if we could simplify buttons styling and have some
> basic button class with the defaults. Right now we have quite many
> "border-radius: 2px":
> http://dxr.mozilla.org/mozilla-central/search?q=%22border-
> radius%3A+2px%22+path%3Abrowser%2Fcomponents%2Floop. Some of the code tries
> to be styled a little bit like Bootstrap (btn class) but some of it does
> not. What do you think?

(just seeing your comment now, please use needinfo to make sure that questions/comments don't go unnoticed)

Yeah it's a shared criticism of the CSS that it could use better organization. We're not planning on fixing up the CSS though until the feature is fully released and then we will start on refactoring/clean-up.
https://hg.mozilla.org/mozilla-central/rev/020fe1a54d84
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [UX][fixed in fx-team] → [UX]
Target Milestone: --- → mozilla36
Comment on attachment 8510651 [details] [diff] [review]
Patch

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8510651 - Flags: approval-mozilla-aurora?
Attachment #8510651 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter

Comment 9

3 years ago
Please ignore.  This is a test on 2 bugs that i'm hoping only I'll notice (since they are so old) to see if this type of multi-change works.  will change status back to resolved fix just to keep clean data.
Resolution: FIXED → WONTFIX
Reporter

Updated

3 years ago
Resolution: WONTFIX → FIXED
You need to log in before you can comment on or make changes to this bug.