1077703 - Add mochitest-bc-e10s to trychooser

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dave Townsend [:mossop]]

I can never remember the syntax for getting e10s test runs :(

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Dupe of bug 1057301?

Comment 2

[Dave Townsend [:mossop]]

(In reply to Bill McCloskey (:billm) from comment #1)
> Dupe of bug 1057301?

That added support for the plain mochitest, not the browser-chrome ones though

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'll take a shot at this.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Add mochitest-bc-e10s to trychooser

Can you review this, Ed? 

I'm assuming the syntax in the bug summary is the correct syntax for this.

Comment 5

[Dave Townsend [:mossop]]

(In reply to Wes Kocher (:KWierso) from comment #4)
> Created attachment 8505901 [details] [diff] [review]
> Add mochitest-bc-e10s to trychooser
> 
> Can you review this, Ed? 
> 
> I'm assuming the syntax in the bug summary is the correct syntax for this.

I don't think that that is a safe assumption

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8505901 [details] [diff] [review]
Add mochitest-bc-e10s to trychooser

Looks good :-)

After you land this, you should be able to deploy the change yourself now due to bug 1017635, see deploy instructions at:
https://wiki.mozilla.org/ReleaseEngineering/How_To/Update_the_Try_Syntax

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8505901 [details] [diff] [review]
Add mochitest-bc-e10s to trychooser

Sorry raced with the previous comment.

Looking closer, this needs to be either:
mochitest-e10s-browser-chrome-1
mochitest-e10s-browser-chrome-2
mochitest-e10s-browser-chrome-3

Or else we also need a change to:
http://mxr.mozilla.org/build-central/source/buildbotcustom/try_parser.py#14

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v2

This works, I think. 

Are these supposed to be selected if I check the "all" box for Unit Test Suites or the "mochitests (all)" checkboxes?

It is pretty wordy. Should I shorten the displayed text, but leave the proper values to make these fit a bit better?

I think in the long run it might be better to change the name in buildbot for these to match up better with the non-e10s versions, though.

Comment 9

[Ed Morley [:emorley]]

Comment on attachment 8506418 [details] [diff] [review]
v2

(In reply to Wes Kocher (:KWierso) from comment #8)
> Are these supposed to be selected if I check the "all" box for Unit Test
> Suites or the "mochitests (all)" checkboxes?

Yeah

> It is pretty wordy. Should I shorten the displayed text, but leave the
> proper values to make these fit a bit better?

Perhaps just leave as is (as long as the text is readable, else tweak the CSS), since it might be confusing otherwise.

> I think in the long run it might be better to change the name in buildbot
> for these to match up better with the non-e10s versions, though.

Agreed :-)

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Landed in https://hg.mozilla.org/build/tools/rev/155af056da7d

I'm connected to the VPN, but I'm apparently not doing something right to log in to relengwebadm, so I'm unable to deploy.

Comment 11

[Ed Morley [:emorley]]

Are you logging in with your moco username (just the part before the @) and ssh key? (either specified in  ssh config or on the command line) you then |sudo su -| after that.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Okay, that worked, thanks! Deployed, and just checked that it's working (or at least, the new options in trychooser are there).

Comment 13

[Ed Morley [:emorley]]

(In reply to Wes Kocher (:KWierso) from comment #12)
> Okay, that worked, thanks! Deployed, and just checked that it's working (or
> at least, the new options in trychooser are there).

Great :-)

I've update the wiki page to make the ssh instructions clearer (https://wiki.mozilla.org/index.php?title=ReleaseEngineering%2FHow_To%2FUpdate_the_Try_Syntax&diff=1026423&oldid=987668).