Closed
Bug 1077742
Opened 8 years ago
Closed 8 years ago
IonMonkey: Make liveIn an array of BitSets, rather than an array of pointers to BitSets
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: sunfish, Assigned: sunfish)
Details
Attachments
(1 file)
23.30 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
The attached patch makes LiveRangeAllocator's liveIn sets arrays of BitSets rather than arrays of pointers to BitSets, eliminating some indirection.
Attachment #8499893 -
Flags: review?(sstangl)
Comment 1•8 years ago
|
||
Comment on attachment 8499893 [details] [diff] [review] bitset-value.patch Review of attachment 8499893 [details] [diff] [review]: ----------------------------------------------------------------- Holy long turnaround time, Batman! Does this patch even apply anymore? If I haven't looked at my queue in what seems to be an absurdly long amount of time, please feel free to poke me to actually take a look. ::: js/src/jit/BitSet.h @@ -167,5 @@ > index_++; > value_ >>= 1; > > skipEmpty(); > - return *this; Isn't it strange to not return the Iterator with postfix ++? A slightly more typical way would be to only support the prefix ++.
Attachment #8499893 -
Flags: review?(sstangl) → review+
Assignee | ||
Comment 2•8 years ago
|
||
> ::: js/src/jit/BitSet.h > @@ -167,5 @@ > > index_++; > > value_ >>= 1; > > > > skipEmpty(); > > - return *this; > > Isn't it strange to not return the Iterator with postfix ++? A slightly more > typical way would be to only support the prefix ++. The patch also changes it to prefix ++ :-). https://hg.mozilla.org/integration/mozilla-inbound/rev/5f41156dbd4c
Comment 3•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5f41156dbd4c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•