1077742 - IonMonkey: Make liveIn an array of BitSets, rather than an array of pointers to BitSets

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: bitset-value.patch

The attached patch makes LiveRangeAllocator's liveIn sets arrays of BitSets rather than arrays of pointers to BitSets, eliminating some indirection.

Comment 1

[Sean Stangl [:sstangl]]

Comment on attachment 8499893 [details] [diff] [review]
bitset-value.patch

Review of attachment 8499893 [details] [diff] [review]:
-----------------------------------------------------------------

Holy long turnaround time, Batman! Does this patch even apply anymore?

If I haven't looked at my queue in what seems to be an absurdly long amount of time, please feel free to poke me to actually take a look.

::: js/src/jit/BitSet.h
@@ -167,5 @@
>          index_++;
>          value_ >>= 1;
>  
>          skipEmpty();
> -        return *this;

Isn't it strange to not return the Iterator with postfix ++? A slightly more typical way would be to only support the prefix ++.

Comment 2

[Dan Gohman [:sunfish]]

> ::: js/src/jit/BitSet.h
> @@ -167,5 @@
> >          index_++;
> >          value_ >>= 1;
> >  
> >          skipEmpty();
> > -        return *this;
> 
> Isn't it strange to not return the Iterator with postfix ++? A slightly more
> typical way would be to only support the prefix ++.

The patch also changes it to prefix ++ :-).

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f41156dbd4c

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f41156dbd4c