Add files which don't pass jshint from apps/bluetooth to .jshintignore

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Build
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: ShellHacker, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

There are some .js files which return errors when hint is run, these file paths aren't still a part of .jshintignore

These have to be added and then cleaned up to pass jshint.

|deviceList.js | and |transfer.js | fail the test.
(Reporter)

Updated

4 years ago
Blocks: 1077770
(Reporter)

Updated

4 years ago
No longer blocks: 1077770
Depends on: 1077770
(Reporter)

Comment 1

4 years ago
Created attachment 8499960 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24781

Yuren,

Could you please check if this is fine. Adding this should clear the other related bugs.

The tracker Bug is 1077770 which is blocked by this bug.
Attachment #8499960 - Flags: review?(yurenju)
(Reporter)

Comment 2

4 years ago
Fabrice, Could you please review this and merge.

It is going to help clear the Lint/Hint issues in those js files. The tracker for the hint fix is bug 1077770
Flags: needinfo?(fabrice)
Comment on attachment 8499960 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24781

The Gij failures need to be investigated.
Attachment #8499960 - Flags: review?(yurenju)
Flags: needinfo?(fabrice)
(Reporter)

Comment 4

4 years ago
I think the Gij failures are intermittent failures filed as bug 1061390 and has no relation to the code changed in the pull request.
Flags: needinfo?(fabrice)
(Reporter)

Updated

4 years ago
Flags: needinfo?(fabrice)
https://github.com/mozilla-b2g/gaia/commit/b9759b9b80847dfd39493da411eb2d1e432e3970
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(fabrice)
Resolution: --- → FIXED
Why would we do this?  These files should be fixed, and not ignored. Files in .jshintignore are generally for third party scripts which will not be passable on jshint.

These files should be fixed and removed from xfail.list - there's nothing that we should add to .jshintignore.

Reverted: https://github.com/mozilla-b2g/gaia/commit/cdfa2f9943a729e7a682212a0ce4d24d965e041e
Flags: needinfo?(sudheesh1995)
Resolution: FIXED → WONTFIX
Note: if you are not running 'make hint', you need to pass in the NO_XFAIL=1 option.
(Reporter)

Comment 8

4 years ago
Kevin,

These files will be fixed and not left to be ignored. These files are currently failing jshint, so the process to fix these has been organized in these steps.

1077769 - Add these files to .jshintignore
1077771 & 1077772 - Fix these files by removing those line from .jshintignore
1077770 - The tracking to check if the other the two files are fixed.

So these files are going to be fixed but its just that adoption of a long way to do it step by step. I think the revert should be reverted again. so that it could be solved.

xfail.list has the files corresponding to css errors and warnings, we have lint problems, maybe the best would be to solve both of them together ?
Status: RESOLVED → REOPENED
Flags: needinfo?(sudheesh1995) → needinfo?(kgrandon)
Resolution: WONTFIX → ---
Please do not add any more files to .jshintignore. Anything we are planning on fixing should be added to the xfail.list here: https://github.com/mozilla-b2g/gaia/blob/master/build/jshint/xfail.list

If they are causing problems, it's because you're not executing the command properly, you should use NO_XFAIL=1.

Let's simply fix the files and remove them from xfail.list.
Flags: needinfo?(kgrandon)
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.