1077772 - Fix jshint error in apps/bluetooth/js/transfer.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Comment 1

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25057

All green. Requesting review.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8503724 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25057

Thank you for the patch. Unfortunately for our CI to catch this, it needs to be removed from xfail.list, otherwise this doesn't have much benefit. You can find xfail.list here: https://github.com/mozilla-b2g/gaia/blob/master/build/jshint/xfail.list

Please address and re-flag me. Thanks!

Comment 3

[Sudheesh Singanamalla (:ShellHacker)]

Kevin,

Sorry I forgot to commit that file after running make hint for APP=bluetooth. Fixed that now.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8503724 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25057

I don't see an official module listed for this, but I guess Ian should review this one? Ian - do you mind taking a look? Thanks!

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 8503724 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25057

There is no jshint error after applied the patch here. Thanks for Sudheesh's help:) r+ with me

Comment 6

[Sudheesh Singanamalla (:ShellHacker)]

Kevin,

Could you land this for me ?

Comment 7

[Kevin Grandon :kgrandon]

Sure, I don't mind. Though in the future you can use checkin-needed once you receive an R+. Thanks for your contribution.

In master: https://github.com/mozilla-b2g/gaia/commit/a8c43ca3e07a8cebb650f383e246aa969ca38e8a