1077873 - Skills suggestion list keeps going after page content ends

Status: RESOLVED INVALID

(Participation Infrastructure :: Phonebook, defect)

Description

[Dmytro Shvets]

Attachment: Skill list.mp4

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141002185629

Steps to reproduce:

In the Skills section click once in the field to add a new skill.
Enter 1/more characters to see a list of skill suggestions below.


Actual results:

The list is too long and keeps going after the content of the page ends.


Expected results:

The list ends together with the content of the page.
OR 
A scroll bar appears in the small window to enable user to scroll through the list of suggestions.

Comment 1

[John Giannelos [:nemo-yiannis]]

:wbowling

Any ideas why this is happening? Could you please take a look?

Comment 2

[Matt Brandt [:mbrandt]]

Attachment: qa - screenshot of bug on prod

Comment 3

[Wray Bowling [:wbowling]]

Fixing this today. FYI, here's how the fix works:

adding this to tagit.

.tagit-autocomplete{
    max-height: 20em; /* twenty rows of text */
    overflow-y: scroll;
}

bonus: adding the .scroll-shadows class that is already on the locations list and changing jQueryUI's background color to white so the shadows show up.

Comment 4

[Wray Bowling [:wbowling]]

Well I found the right place to put the styles but unfortunately the javascript which positions the auto-complete selections is placing the selection menu at 0px 0px instead of just below the text field.

I'm going to turn this into an issue with the tag-it developer, modify the plugin, and submit a pull request to him. No one should have to deal with this.

Comment 5

[Wray Bowling [:wbowling]]

Alternatively, if one of you savvy back-end people would like to simply put a limit on the results that get sent to the tag-it autocomplete somewhere between 5–20 that would do the trick just as well.

Comment 6

[Wray Bowling [:wbowling]]

https://github.com/aehlke/tag-it/issues/121 <- The issue is here.

Comment 7

[Wray Bowling [:wbowling]]

bug fix branch started here: https://github.com/caktus/mozillians/tree/1077873-skills-run-off-page

Comment 8

[Nikos Roussos [:comzeradd]]

With the recent changes on profle edit UI this no longer relevant. The autocomplete skills dropdown menu has a scroll bar now.