2.77 KB, patch
|Details | Diff | Splinter Review|
40.24 KB, text/plain
4.70 KB, text/plain
After the rewrite and some bake time we can add the new SOAP to installers.
Assignee: heikki → rayw
Tentatively scheduling for 0.9.7.
Depends on: 107795
Target Milestone: --- → mozilla0.9.7
Target milestone changed.
Target Milestone: mozilla0.9.7 → mozilla0.9.8
18 years ago
18 years ago
Now that SOAP has become part of the default build, it needs to be packaged. Here is the patch to do that.
Comment on attachment 70820 [details] [diff] [review] Add xmlsoap.xpt to the packager in 5 files (everywhere xmlextras was). r/sr=vidur
Attachment #70820 - Flags: superreview+
I do not believe that my changes caused the errors, but I clearly need to have someone look at it who understands installer better than I do.
Comment on attachment 70820 [details] [diff] [review] Add xmlsoap.xpt to the packager in 5 files (everywhere xmlextras was). r=dveditz Looks like the right thing
Attachment #70820 - Flags: review+
The missing component warnings are noise from people who forget to take obsolete files out. The build team files bugs on this from time to time because the bogus warnings get in the way of figuring out when the build has broken. For example, it appears you didn't build security and that's the kind of thing the build team does want warnings about. The zip error looks like it's calling a different zip program than the one that worked earlier. I'm guessing we should change the script to just pick up whatever's on your path now that zip has long been a standard requirement. Either copy your cygwin zip into your moztools\bin directory, or edit line 375 of mozilla/xpinstall/packager/windows/makeall.pl to remove the path from the zip command.
Comment on attachment 70820 [details] [diff] [review] Add xmlsoap.xpt to the packager in 5 files (everywhere xmlextras was). a=dbaron for 0.9.9
Attachment #70820 - Flags: approval+
This patch was checked in, thanks to all who helped.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Changing Q/A contact
QA Contact: petersen → rakeshmishra
verified the patch on trunk build 2002-06-07-04-trunk. marking verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.