107798 - search-panel.js still needs cleanup

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect)

Description

[Brian Nesse (gone)]

I missed one JS strict warning on my last check in, and there were some tabs and
other scattered readability/correctness issues that bugged me too.

Patch coming.

Comment 1

[Brian Nesse (gone)]

Attachment: Patch to clean up search-panel.js

Comment 2

[Alec Flett]

Comment on attachment 55943 [details] [diff] [review]
Patch to clean up search-panel.js

wow, you're becoming a regular mozilla janitor like me! :)
As long as the spacing matches the modeline at the top of the file, then sr=alecf
(I'm not a fan of 2-space indenting :))

Comment 3

[Brian Nesse (gone)]

Yes, the modeline is 2 that's why I changed those functions. Everything else in
the file also appears to be 2, which is why it caught my attention in the first
place.

Comment 4

[Samir Gehani]

Comment on attachment 55943 [details] [diff] [review]
Patch to clean up search-panel.js

Thanks again Brian.  r=sgehani

Comment 5

[Samir Gehani]

*** Bug 83020 has been marked as a duplicate of this bug. ***

Comment 6

[Brian Nesse (gone)]

Checked in.

Comment 7

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]