1078018 - Button's badge needs to be documented

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Matteo Ferretti [:zer0] [:matteo]]

See bug 994280

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Will, can you take a look at this?

Comment 2

[Will Bamberg [:wbamberg]]

I looked at this a couple of weeks ago and it looked like badged buttons hadn't been uplifted, so I didn't document them. Looking at it again, it seems they still haven't?

Comment 3

[Will Bamberg [:wbamberg]]

Matteo:
https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_toggle#Badged_buttons
https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_action#Badged_buttons

Let me know if this is all right.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

As mentioned face to face, looks good to me, just some minor changes:

1) Mentioned the four characters limit (Any string or number can be passed, but only four would be displayed)
2) Use a screenshot that shows the default badge color instead a custom one

Comment 5

[Will Bamberg [:wbamberg]]

I've made this 2 updates, so am closing this, but please reopen if it doesn't look right.

https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_toggle
https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_action