1078022 - [en-GB] <span> tags visible in OTA update notification message

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Robbie MacKay]

Attachment: 2014-10-06-09-14-36.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

1. Set language to English (GB)
2. Check for updates (Settings -> Device Information -> Check Now)
3. Click notification to run the OTA update


Actual results:

<span> tags are visible in the notification.
"1 update available. <span>Tap for more info</span>"

Similarly <span> tags appear in notifications during update:
"Downloading update: <span>42MB downloaded</span>"
And then
"Uncompressing update... <span>this may take a few minutes</span>"


Expected results:

Notifications should appear without <span> tags.
 
In en_US locale this appears to work as expected

Comment 1

[Robbie MacKay]

This is happening in the latest flame-aurora-kk build

I suspect this is might be a missing/non working locale since it happens in en_GB, but not en_US

Comment 2

[Théo Chevalier]

Some locales are affected, here's why:

Initially the entities for those strings were, for instance: updateAvailableInfo[one]
Then they've been changed to updateAvailableInfo.innerHTML[one] between v1.1 and v1.2.

So the locales that have not updated to the latest strings are falling back to the old translations  without ".innerHTML" (because they are sharing the same root as entity name), it explains why HTML tags are displayed in the UI.
en-GB is still using the old ones for instance:  http://hg.mozilla.org/gaia-l10n/en-GB/file/default/apps/system/system.properties#l121


To avoid that, we should have updated the entity name itself, like updateAvailableInfo2.innerHTML[one].

Not sure what's best to do:
- fixing master with new entities to make sure no locale will ever ship with old strings (in case locales are shipping with missing strings). But that will work only for 2.2
- Warning localizers by filling individual bugs for those locales.
- Don't do anything since there is a low risk locales are shipping with incomplete l10n (Maybe fix en-GB manually, since it's kind of a special case).

Delphine, Flod, any thoughts?

Potentially affected locales are locales with a blank line here http://transvision.mozfr.org/string/?entity=apps/system/system.properties:updateAvailableInfo.innerHTML%5Bone%5D&repo=gaia
ast, en-GB, et, he, lij.

Comment 3

[Théo Chevalier]

Actually, here's a better overview of the affected locales: http://mxr.mozilla.org/l10n-gaia/search?string=updateAvailableInfo%5Bone%5D

ast, en-GB, lij

No 1.3 locales seems affected, can't check on 2.0 with MXR.

Comment 4

[Francesco Lodolo [:flod]]

Given the list of locales (small, AFAIK not shipping with partners), I'd file individual bugs and move this one to en-GB, without bothering people with a new string.

Comment 6

[Delphine Lebédel [:delphine - OOO]]

Don't think there's anything needed from me anymore here, so clearing the ni.

Comment 8

[daniel.james]

Duplicate of this bug: 1089329

Comment 9

[daniel.james]

https://bugzilla.mozilla.org/show_bug.cgi?id=1089329

Comment 10

[Théo Chevalier]

Indeed, thanks

Comment 12

[Ian Neal]

Is anything still needed here? Looking at the mxr link it seems there are lots of locales that have <span> in the referenced string.

Comment 13

[Francesco Lodolo [:flod]]

I don't think this string exist anymore anywhere, but it's hard to tell after 2 years (Gaia 1.3 is not supported on Transvision). At some point this switched to .innerHTML, but after we removed all .innerHTML in 2.x

Given the status of Gaia, I would WONTFIX this anyway.

Comment 14

[Théo Chevalier]

(In reply to Ian Neal from comment #12)
> Is anything still needed here? Looking at the mxr link it seems there are
> lots of locales that have <span> in the referenced string.

All locales have been fixed, the bug can be closed.
Thanks!