Closed
Bug 1078067
Opened 11 years ago
Closed 11 years ago
Remove custom background from Loop panel
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox34 fixed, firefox35 fixed)
People
(Reporter: ntim, Assigned: ntim)
Details
(Whiteboard: [good first verify][loop-uplift])
Attachments
(1 file)
|
1.16 KB,
patch
|
mikedeboer
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The background applied on the panel makes it look inconsistent with other panels, and should be removed.
|
Assignee | |
Updated•11 years ago
|
Summary: Remove background from Loop panel → Remove custom background from Loop panel
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8500176 -
Flags: review?(mdeboer)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8500176 [details] [diff] [review]
Patch v1
Review of attachment 8500176 [details] [diff] [review]:
-----------------------------------------------------------------
I like it! Thanks for correcting my mistake :)
Attachment #8500176 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla35
Untracked for QE verification, although this would be a good first bug for a contributor to verify.
Flags: qe-verify-
Whiteboard: [good first verify]
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8500176 [details] [diff] [review]
Patch v1
Approval Request Comment
Part of the staged Loop aurora second uplift set
Attachment #8500176 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•11 years ago
|
Whiteboard: [good first verify] → [good first verify][loop-uplift]
|
|
||
Comment 7•11 years ago
|
||
|
|
||
Updated•11 years ago
|
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
|
||
Comment 8•11 years ago
|
||
Comment on attachment 8500176 [details] [diff] [review]
Patch v1
Already landed, tacking for posterity.
Attachment #8500176 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Updated•11 years ago
|
Iteration: --- → 35.3
You need to log in
before you can comment on or make changes to this bug.
Description
•