Closed Bug 1078067 Opened 9 years ago Closed 9 years ago

Remove custom background from Loop panel

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox34 fixed, firefox35 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla35
Iteration:
35.3
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: ntim, Assigned: ntim)

Details

(Whiteboard: [good first verify][loop-uplift])

Attachments

(1 file)

Patch v1
1.16 KB, patch
mikedeboer
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
The background applied on the panel makes it look inconsistent with other panels, and should be removed.
Summary: Remove background from Loop panel → Remove custom background from Loop panel
Attached patch Patch v1 — — Splinter Review 

        Attachment #8500176 -
        Flags: review?(mdeboer)

    
  
Assignee: nobody → ntim007
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8500176 [details] [diff] [review]
Patch v1

Review of attachment 8500176 [details] [diff] [review]:
-----------------------------------------------------------------

I like it! Thanks for correcting my mistake :)

        Attachment #8500176 -
        Flags: review?(mdeboer) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b0a3f046e716
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla35

    
    

    
  
Untracked for QE verification, although this would be a good first bug for a contributor to verify.
Flags: qe-verify-
Whiteboard: [good first verify]

    
    

    
  
Comment on attachment 8500176 [details] [diff] [review]
Patch v1

Approval Request Comment
Part of the staged Loop aurora second uplift set

        Attachment #8500176 -
        Flags: approval-mozilla-aurora?
Whiteboard: [good first verify] → [good first verify][loop-uplift]

    
    

    
  
Comment on attachment 8500176 [details] [diff] [review]
Patch v1

Already landed, tacking for posterity.

        Attachment #8500176 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Iteration: --- → 35.3

          You need to log in
          before you can comment on or make changes to this bug.