Closed
Bug 1078223
Opened 10 years ago
Closed 10 years ago
Unhandled IRC messages: 598 and 599
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(thunderbird34 fixed, thunderbird35 fixed, thunderbird_esr3134+ fixed)
RESOLVED
FIXED
1.6
People
(Reporter: florian, Assigned: aleth)
References
()
Details
(Whiteboard: [1.6-blocking])
Attachments
(1 file, 3 obsolete files)
2.44 KB,
patch
|
aleth
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
standard8
:
approval-comm-esr31+
|
Details | Diff | Splinter Review |
I'm seeing these since the moznet servers have been migrated to the new network: Warning: Unhandled IRC message: :fripp.mozilla.org 598 clokep Instantbird moz-uogj6q.cable.rcn.com 1412591115 :I am currently away from the computer. Source File: resource://gre/components/irc.js Line: 691 Source Code: prpl-irc: ircSocket.prototype.onDataReceived Warning: Unhandled IRC message: :fripp.mozilla.org 599 clokep Instantbird moz-uogj6q.cable.rcn.com 1412591148 :is no longer away Source File: resource://gre/components/irc.js Line: 691 Source Code: prpl-irc: ircSocket.prototype.onDataReceived Interestingly, it seems we do have code to handle these messages: http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircWatchMonitor.jsm#196
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.6-blocking]
Assignee | ||
Comment 1•10 years ago
|
||
This fixes the problem on moznet. I'm a bit surprised 598 and 599 have less parameters than the others though, e.g. compare :fripp.mozilla.org 599 clokep_work Instantbird moz-tej.o7i.10.19.IP 1413303402 :is no longer away and :fripp.mozilla.org 604 aleth-build aleth Instantbird moz-0grteb.pools.vodafone.de 1413300162 :is online I hope that isn't a server quirk.
Attachment #8505057 -
Flags: feedback?(clokep)
Comment 2•10 years ago
|
||
Does this just fix the warnings or is there a bigger issue this fixes? (Disappearing nicks perhaps?) This fix scares me a lot since it implies different servers are behaving differently. How was this tested?
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #2) > Does this just fix the warnings or is there a bigger issue this fixes? > (Disappearing nicks perhaps?) The status of buddies in the contact list isn't being updated correctly, as we try to find a buddy using the username instead of the nick. > This fix scares me a lot since it implies different servers are behaving > differently. How was this tested? Indeed, that's why it's f?. So far it's been tested on moznet only and I don't know yet how other WATCH implementations behave. Could be an inspircd bug.
Assignee | ||
Comment 4•10 years ago
|
||
Assignee: nobody → aleth
Attachment #8505057 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8505057 -
Flags: feedback?(clokep)
Attachment #8507395 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Comment 5•10 years ago
|
||
Comment on attachment 8507395 [details] [diff] [review] fixirc.diff 2 Review of attachment 8507395 [details] [diff] [review]: ----------------------------------------------------------------- I wonder if we should include in the comment what version this is fixed in for inspircd. ::: chat/protocols/irc/ircWatchMonitor.jsm @@ +198,5 @@ > > "598": function(aMessage) { // RPL_GONEAWAY > // <nickname> <username> <hostname> <awaysince> :<away reason> > + // We use a negative index as inspircd doesn't send the user's nick as > + // the first parameter (see bug 1078223). I believe this is the referred the "target". So yes, they definitely should be including this.
Attachment #8507395 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Improved comment as inspircd just fixed this bug for inspircd v2.0.18.
Attachment #8507395 -
Attachment is obsolete: true
Attachment #8507407 -
Flags: review?(clokep)
Comment 7•10 years ago
|
||
Comment on attachment 8507407 [details] [diff] [review] fixirc.diff 3 Review of attachment 8507407 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/protocols/irc/ircWatchMonitor.jsm @@ +198,5 @@ > > "598": function(aMessage) { // RPL_GONEAWAY > // <nickname> <username> <hostname> <awaysince> :<away reason> > + // We use a negative index as inspircd versions < 2.0.18 don't send > + // the user's nick asthe first parameter (see bug 1078223). Nit: "as the" in both places. :) You can carry the review forward.
Attachment #8507407 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8507407 -
Attachment is obsolete: true
Attachment #8507417 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/d02cd637eea5 Should we back port this to tb 31?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Reporter | ||
Comment 10•10 years ago
|
||
I would say yes.
Assignee | ||
Comment 11•10 years ago
|
||
We'd like to uplift this to TB31 as it badly affects IRC on inspircd servers such as, since recently, moznet. There doesn't seem to be an appropriate flag to set as this bug is not in the TB component, so using needinfo.
Flags: needinfo?(standard8)
Comment 12•10 years ago
|
||
I would suggest that we extend the approval-comm-* flags here, as well as the tracking/status-thunderbird* ones. I've already extended the attachment flags, the tracking flags are bug 1089666. The target milestone tracking will be a bit difficult, but we might just have to live with that being different for now.
Flags: needinfo?(standard8)
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8507417 [details] [diff] [review] fixirc.diff 4 [Approval Request Comment] Regression caused by (bug #): Bug in inspircd v2.0, as used by moznet User impact if declined: incorrect presence for contacts Testing completed (on c-c, etc.): works well Risk to taking this patch (and alternatives if risky): none I can see
Attachment #8507417 -
Flags: approval-comm-esr31?
Attachment #8507417 -
Flags: approval-comm-beta?
Attachment #8507417 -
Flags: approval-comm-aurora?
Updated•10 years ago
|
Attachment #8507417 -
Flags: approval-comm-beta?
Attachment #8507417 -
Flags: approval-comm-beta+
Attachment #8507417 -
Flags: approval-comm-aurora?
Attachment #8507417 -
Flags: approval-comm-aurora+
Comment 14•10 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/1995aa350f35
status-thunderbird35:
--- → fixed
Comment 15•10 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/7a1c94333d8d
status-thunderbird34:
--- → fixed
Updated•10 years ago
|
Attachment #8507417 -
Flags: approval-comm-esr31? → approval-comm-esr31+
Comment 16•10 years ago
|
||
https://hg.mozilla.org/releases/comm-esr31/rev/2bdf8345e0ce
status-thunderbird_esr31:
--- → fixed
tracking-thunderbird_esr31:
--- → 34+
You need to log in
before you can comment on or make changes to this bug.
Description
•