Closed Bug 1078251 Opened 6 years ago Closed 6 years ago

Bump Firefox Version for plugincheck - Fx 33 will be released on 2014-10-14

Categories

(Plugin Check :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dj.4bug, Unassigned)

Details

(Whiteboard: [kb=1533064])

Schalk,

I know that you have MANY things to do!

I doubt that all of the plugincheck bugs will be completed and tested
before Firefox 33 is released.

So, in order to prevent more bugs like
Bug 1062244, bug 1023718, bug 1061985, bug 1062393, bug 1023946, bug 1062236 etc.

Please can you 'Bump Firefox Version' for plugincheck so that on
Tuesday 2014-10-07,
Fx 33 (and older) will use the 'existing plugincheck - uses enumeration' and
Fx 34+ will use the 'new plugincheck - uses the JSON List'.

Some Bedrock bugs seem to take more than 24 hours to complete so I am
recommending that this is done now.


FAO Kev Needham and Schalk Neethling.

Removal of Plugin Finder Service (PFS) from Firefox

I hope that you saw this:

Justin Dolske [:Dolske] on 2014-09-26 in bug 573834 comment # 9 said: 

> Bug 836415 has now removed the Plugin Finder Service (PFS) from Firefox.
> As a result, I'm closing all the remaining PFS bugs.
> 
> If you're getting this bugmail for an ancient PFS bug, the basic summary of the
> world today is:
> 
> * NPAPI plugins are a dying technology
> * PFS was already restricted to assisting with only the 4 most common plugins
> * Sites commonly provide their own UI for install a required plugin
> * Mozilla is generally focusing on  improving the web platform so that proprietary 
>   plugins are not required.
> 
> (Note that "plugins" are a completely separate from "browser extensions", such at
> those found on addons.mozilla.org. The latter are not going anywhere, and are not
> impacted by the removal of PFS.)

and also
Justin Dolske [:Dolske] on 2014-09-18 in bug 836415 comment # 16 said:

> I've closed the remaining 62 open bugs in Toolkit :: Plugin Finder Service, and
> filed bug 1069487 to inactivate that component in bugzilla.


Please can you confirm that neither
'existing plugincheck using enumeration'
or
'new plugincheck - uses the JSON List'
depends on *any* of the PFS that is being removed.



In bug 1020133 comment # 30 onwards I showed that 
'plugincheck using enumeration' still used

> https://plugins.mozilla.org/pfs/v2?appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384} ... ... 
See
https://bug1020133.bugzilla.mozilla.org/attachment.cgi?id=8487593
which is discussed in bug 1020133 comment # 32.

So, while I don't think the 'plugincheck database' is being removed
I do wonder if any 'extraction of relevant data from the database'
still depends on PFS or PFS2.


References:
Bug 1060905 "Bump Firefox Version for plugincheck - Fx 32 will be released on 2014-09-02"
In this case, Fx 32 Release was Released BEFORE the Bedrock push had completed.
 
Bug 1041509 "Bump Fx Version to 31 for plugincheck"

For more background, history, list of some outstanding bugs, comments on tests:
see bug 956905 comment # 148.

"Firefox/Features/PFS2 datasource"
https://wiki.mozilla.org/Firefox/Features/PFS2_datasource

DJ-Leith
Flags: needinfo?(schalk.neethling.bugs)
Flags: needinfo?(kev)
Thanks DJ. Will have to bump again as I am still blocked on getting a staging environment.
Flags: needinfo?(schalk.neethling.bugs)
(In reply to Schalk Neethling from comment #1)
> Thanks DJ. Will have to bump again as I am still blocked on getting a staging environment.

I guessed that from bug 1020133 comment # 64.

I'm still keen to have your considered opinion about PFS and PFS2.

(from comment # 0)
> Please can you confirm that neither
> 'existing plugincheck using enumeration'
> or
> 'new plugincheck - uses the JSON List'
> depends on *any* of the PFS that is being removed.
Is there any dependency?

DJ-Leith
No, neither should depend on that at all. That uses a file called pfs.py to track things and plugincheck uses the DB on plusing.m.o
Whiteboard: [kb=1533064]
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ef7988741bb94e3fb29a7fd64a75dddce536b25c
Fix Bug 1078251, bump plugincheck fx version check to 33

https://github.com/mozilla/bedrock/commit/504e15db8bef6eafd9d18d5daf147e741c3be5e2
Merge pull request #2345 from ossreleasefeed/bug1078251-bump-plugincheck-fx-version-check-to-33

Fix Bug 1078251, bump plugincheck fx version check to 33
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Flags: needinfo?(kev)
You need to log in before you can comment on or make changes to this bug.