Closed Bug 1078284 Opened 10 years ago Closed 7 years ago

Intermittent test_runtime.html | Test timed out. - expected PASS

Categories

(DevTools Graveyard :: WebIDE, defect, P3)

x86
Linux
defect

Tracking

(firefox47 wontfix, firefox48 wontfix, firefox49 wontfix, firefox50 affected, firefox51 affected, firefox52 wontfix, firefox56 fixed, firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox47 --- wontfix
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- affected
firefox51 --- affected
firefox52 --- wontfix
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: cbook, Assigned: ochameau)

References

()

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(2 files)

Ubuntu VM 12.04 x64 mozilla-central pgo test mochitest-other

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=452434&repo=mozilla-central

05:00:08 INFO - 158 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/browser/devtools/webide/test/test_runtime.html | Test timed out. - expected PASS
It looks like it can possibly be just a `yield waitFor` that need to be rewritten to 
`let onWait = waitFor; ... yield onWait;`

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40608a8386ea
So adding some logs is enough to fix that bug,
but doing that seems to not be enough given the previous try run :/
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Looks like an indexed db issue:
01:49:35     INFO -  645 INFO TEST-START | devtools/client/webide/test/test_runtime.html
01:49:36     INFO -  646 INFO WebIDE open
01:49:36     INFO -  openedWebIDE
01:49:36     INFO -  update(runtime-list)
01:49:36     INFO -  update(runtime-list) done
01:49:36     INFO -  importPackagedApp
01:49:36     INFO -  importAndSelectApp: true
01:49:36     INFO -  AppProject.IDB.add
01:49:36     INFO -  importAndSelectApp exception: Unable to add project to the AppProjects indexedDB: ConstraintError - A mutation operation in the transaction failed because a constraint was not satisfied. For example, an object such as an object store or index already exists and a new one was being attempted to be created.
Mass wontfix for bugs affecting firefox 52.
Hi Alexandre, that uptick for this failure looks like fallout from bug 1353656. Please take a look at this.
Flags: needinfo?(poirot.alex)
Whiteboard: [stockwell needswork]
I was finally able to get useful data from this run!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad8f1aabdec13deb6034932bcb34b3df800bbe7a

http://searchfox.org/mozilla-central/source/devtools/client/webide/content/webide.js#637
This line throws silently this exception:
Unable to add project to the AppProjects indexedDB: ConstraintError - A mutation operation in the transaction failed because a constraint was not satisfied. For example, an object such as an object store or index already exists and a new one was being attempted to be created.

I thought our indexed-db helper was preventing that. I imagine another test overlap with this one and introduce concurrent database request.

jryans, do you remember how we used to address these indexed db issues? I looked into changelog and only saw bug 1024734, which is already about this function...
I'm suggesting the only run WebIDE tests on optimized build given the current status of the project.
It is also intermittent on optimized builds, but only 2 occurences during July, versus tons of them on asan/debug builds.

Julian, do you also agree with that?
Flags: needinfo?(poirot.alex) → needinfo?(jdescottes)
(In reply to Alexandre Poirot [:ochameau] from comment #458)
> I'm suggesting the only run WebIDE tests on optimized build given the
> current status of the project.
> It is also intermittent on optimized builds, but only 2 occurences during
> July, versus tons of them on asan/debug builds.
> 
> Julian, do you also agree with that?

Yes that sounds reasonable.
Flags: needinfo?(jdescottes)
Comment on attachment 8893308 [details]
Bug 1078284 - Disable WebIDE tests on all but optimized builds.

https://reviewboard.mozilla.org/r/164376/#review170296
Attachment #8893308 - Flags: review?(jryans) → review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26e0ae835693
Disable WebIDE tests on all but optimized builds. r=jryans
https://hg.mozilla.org/mozilla-central/rev/26e0ae835693
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee: nobody → poirot.alex
https://hg.mozilla.org/releases/mozilla-beta/rev/df856413bbfb
Whiteboard: [stockwell needswork] → [stockwell disabled]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.