Closed Bug 1078342 Opened 10 years ago Closed 10 years ago

Using closure compile breaks Flocons.swf

Categories

(Firefox Graveyard :: Shumway, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: yury, Unassigned)

References

()

Details

Works in IFRAME and by switching off the closures during the extension build

(P.S. there can be some unrelated AVM1 errors)
The following TS code:

    _insertChildAtDepth(mc: any, depth: number): AVM1MovieClip {
      var nativeAS3Object = <flash.display.MovieClip> this._nativeAS3Object;
      nativeAS3Object.addTimelineObjectAtDepth(mc, Math.min(nativeAS3Object.numChildren, depth));
      // Bitmaps aren't reflected in AVM1, so the rest here doesn't apply.
      if (flash.display.Bitmap.isType(mc)) {
        return null;
      }
      var as2mc = getAVM1Object(mc);
      return as2mc;
    }

is compiled/optimized to:

    s.prototype._insertChildAtDepth = function(a, b) {
      var c = this._nativeAS3Object;
      c.addTimelineObjectAtDepth(a, Math.min(c.numChildren, b));
      e.flash.display.Bitmap.isType(a) || h.getAVM1Object(a);
    };
Yury, can you confirm that this got fixed by https://github.com/mozilla/shumway/pull/1778?
Flags: needinfo?(ydelendik)
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(ydelendik)
Resolution: --- → WORKSFORME
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.