Closed Bug 1078378 Opened 10 years ago Closed 10 years ago

tests failing on test-content-worker

Categories

(Add-on SDK Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zer0, Assigned: zer0)

References

Details

Attachments

(1 file)

We have a lot of TEST-UNEXPECTED-FAIL for test-content-worker, probably because some platform changes about the compartments.

Executing locally the test above, we get this warning:

JavaScript Warning: "Security wrapper denied access to property length on privileged Javascript object. Support for exposing privileged objects to untrusted content via __exposedProps__ is being gradually removed - use WebIDL bindings or Components.utils.cloneInto instead. Note that only the first denied property access from a given global objec t will be reported."

The culprit is `emitSync`, that is there for `context-menu` and it doesn't "stringify" the arguments to pass to the content's sandbox, because they could be not JSONable. In such cases, the code fails, because the content can't access to the array's properties.

Notice that the `emitSync` won't probably work in e10s, but the new context menu API should get rid of it.
Assignee: nobody → zer0
Attachment #8500535 - Flags: review?(dtownsend+bugmail) → review+
Is this the same as bug 1078032?
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/61904a1b1ebb3bca57465b9e8242942a3f5ca8b0
Bug 1078378 - tests failing on test-content-worker

- Replace the array instance used by `emitSync` with one from the content's sandbox

https://github.com/mozilla/addon-sdk/commit/25636ab34af1506d6eda5a41558fe5fa8481b3c8
Merge pull request #1672 from ZER0/fail-content-worker/1078378

fix Bug 1078378 - tests failing on test-content-worker r=@mossop
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.