1078524 - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/mailnews/import/test/unit/test_shiftjis_csv.js

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Magnus Melin [:mkmelin]]

Hadn't seen this before, so filing it now.
I guess the cause is the same as bug 1074585, shift_jis is no longer detected and we just have to live with that. (import is the other caller of MsgDetectCharsetFromFile)

Should we just disable the test for now, or remove it completely?

https://tbpl.mozilla.org/php/getParsedLog.php?id=49630089&tree=Thunderbird-Trunk&full=1#error3

06:30:10  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/mailnews/import/test/unit/test_shiftjis_csv.js | test failed (with xpcshell return code: 0), see following log:
06:30:10     INFO -  >>>>>>>
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [null : 513] true == true
06:30:10     INFO -  TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [GenericImportHelper : 28] {"QueryInterface":"function QueryInterface() {\\n    [native code]\\n}","GetData":"function GetData() {\\n    [native code]\\n}","Se != null
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [AbImportHelper.prototype.getJsonCards : 321] true == true
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [GenericImportHelper.prototype.beginImport : 42] true == true
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [GenericImportHelper.prototype.beginImport : 49] true == true
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [GenericImportHelper.prototype.beginImport : 50] true == true
06:30:10     INFO -  TEST-INFO | (xpcshell/head.js) | test pending (2)
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [GenericImportHelper.prototype.checkProgress : 87] true == true
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [GenericImportHelper.prototype.checkProgress : 89] true == true
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [AbImportHelper.prototype.getAbByName : 260] true == true
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [AbImportHelper.prototype.checkResults : 235] {"QueryInterface":"function QueryInterface() {\\n    [native code]\\n}","uuid":"ldap_2.servers.shiftjisaddressbook&shiftjis_addres != null
06:30:10     INFO -  TEST-PASS | resources/import_helper.js | [AbImportHelper.prototype.checkResults : 236] true == true
06:30:10  WARNING -  TEST-UNEXPECTED-FAIL | resources/import_helper.js | "名無しの権兵衛" == "�������̌����q" - See following stack:
06:30:10     INFO -  resources/import_helper.js:AbImportHelper.prototype.compareCards:283
06:30:10     INFO -  resources/import_helper.js:AbImportHelper.prototype.checkResults:243
06:30:10     INFO -  resources/import_helper.js:GenericImportHelper.prototype.checkProgress:96
06:30:10     INFO -  resources/import_helper.js:GenericImportHelper.prototype.beginImport:52
06:30:10     INFO -  /builds/slave/test/build/tests/xpcshell/tests/mailnews/import/test/unit/test_shiftjis_csv.js:run_test:14
06:30:10     INFO -  /builds/slave/test/build/tests/xpcshell/head.js:_execute_test:403
06:30:10     INFO -  -e:null:1
06:30:10     INFO -  null:null:0

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: A workaround

Please don't disable test.
At least for the test code, this patch is sufficient to pass the test.

I don't actually think the current behavior (after removal universal detector) is good because it works only if a proper "intl.charset.detector" is set.

Comment 2

[Magnus Melin [:mkmelin]]

Looks like a good workaround for the test.
But what should we do for actual usage? Or is that detector activated somehow for Japanese builds?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Yes, the detector it set in localization.

http://hg.mozilla.org/l10n-central/ja/file/6ce31c3a1c68/toolkit/chrome/global/intl.properties#l49

So users who are not using localized version will be suffering if we can not provide proper fix. I am the one of them.;-p

Comment 4

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/53235754028b -> FIXED