Closed Bug 107857 Opened 23 years ago Closed 23 years ago

WRMB:[quirks]Show Empty Table Cells STYLE background-color, and background-image

Categories

(Core :: Layout: Tables, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla0.9.6

People

(Reporter: bc, Assigned: karnaze)

References

Details

(Keywords: topembed, Whiteboard: [bugscape: 94041] PATCH CANDIDATE_094)

Attachments

(6 files)

bug 94041 resulted in the background colors/images displaying in Quirks mode for
empty TDs with BGCOLOR/BACKGROUND attributes.

It seems appropriate to make the solution complete so that in Quirks mode
background colors or background images for table cells will show for empty cells
whether you code the BGCOLOR/BACKGROUND attributes on the cell or you code the
background-color, background-image via CSS. This will duplicate the behavior of
IE 5.5.
adding WRMB bugscape transition notations
Keywords: topembed
Priority: -- → P2
Summary: [quirks]Show Empty Table Cells STYLE background-color, and background-image → WRMB:[quirks]Show Empty Table Cells STYLE background-color, and background-image
Whiteboard: [bugscape: 94041]
Target Milestone: --- → mozilla0.9.6
Status: NEW → ASSIGNED
Whiteboard: [bugscape: 94041] → [bugscape: 94041] PATCH
Comment on attachment 56218 [details] [diff] [review]
change to quirk.css to always show backgrouds on empty cells in quirks mode

r= alexsavulov
Attachment #56218 - Flags: review+
Chris, I think it would be good to get an additional 'r' from Hixie (the gray
eminence of *.css)
Attached patch revised patchSplinter Review
Comment on attachment 56255 [details] [diff] [review]
revised patch

sr=attinasi
Attachment #56255 - Flags: superreview+
what sites are affected by this?
I do not know of any sites that are affected by this. It came out of documenting
the compatibility fix of bug 94041. It seemed inconsistent to tell developers
that bgcolor and background attributes would work on TD in quirks mode but
background-color and background-image CSS rules would not. If this is a big
issue, then mark it wontfix.
-->trunk.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [bugscape: 94041] PATCH → [bugscape: 94041] PATCH CANDIDATE_094
Does this patch cause empty cells (for example on the tinderbox pages) to be
displayed ?
The backgrounds will be displayed like IE does. Is this a problem?
Yes, empty-cells applies to borders too.
Hey karnaze, we now display tinderbox differently than IE (e.g.). Was this patch
too violent?
Yea, I should have realized that a bug this easy has got to be wrong somehow. 
After to talking to attinasi, I need to teach the css parser to recognize a 
value like -moz-show-background-hide-borders on empty-cells.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Comment on attachment 56768 [details] [diff] [review]
patch to add -moz-show-background value to empty-cells and make that the quirk default

r=pierre
Attachment #56768 - Flags: review+
Comment on attachment 56768 [details] [diff] [review]
patch to add -moz-show-background value to empty-cells and make that the quirk default

sr=attinasi - nice non-violent patch
Attachment #56768 - Flags: superreview+
The new patch is in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
*** Bug 108730 has been marked as a duplicate of this bug. ***
*** Bug 108896 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: